From: "Liming Gao" <liming.gao@intel.com>
To: "coeur@gmx.fr" <coeur@gmx.fr>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH] FmpDevicePkg: Fix various typos
Date: Mon, 8 Jul 2019 01:21:05 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A3672@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190705141821.82895-1-coeur@gmx.fr>
Please add Signed-off-by: your name.
The change is good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Antoine Cœur [mailto:coeur@gmx.fr]
>Sent: Friday, July 05, 2019 10:18 PM
>To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kinney,
>Michael D <michael.d.kinney@intel.com>
>Cc: Antoine Cœur <coeur@gmx.fr>
>Subject: [PATCH] FmpDevicePkg: Fix various typos
>
>Fix one typo in FmpDevicePkg.
>---
> FmpDevicePkg/FmpDxe/DetectTestKey.c | 2 +-
> FmpDevicePkg/Include/Library/FmpDeviceLib.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c
>b/FmpDevicePkg/FmpDxe/DetectTestKey.c
>index 52e780dac8..e697a08489 100644
>--- a/FmpDevicePkg/FmpDxe/DetectTestKey.c
>+++ b/FmpDevicePkg/FmpDxe/DetectTestKey.c
>@@ -139,7 +139,7 @@ DetectTestKey (
> }
>
> //
>- // If test key detected or an error occured checking for the test key, then
>+ // If test key detected or an error occurred checking for the test key, then
> // set PcdTestKeyUsed to TRUE.
> //
> if (TestKeyUsed) {
>diff --git a/FmpDevicePkg/Include/Library/FmpDeviceLib.h
>b/FmpDevicePkg/Include/Library/FmpDeviceLib.h
>index 708ebca8c5..c435b23030 100644
>--- a/FmpDevicePkg/Include/Library/FmpDeviceLib.h
>+++ b/FmpDevicePkg/Include/Library/FmpDeviceLib.h
>@@ -73,7 +73,7 @@ RegisterFmpInstaller (
> @retval EFI_INVALID_PARAMETER Size is NULL.
> @retval EFI_UNSUPPORTED The firmware device does not support
>reporting
> the size of the currently stored firmware image.
>- @retval EFI_DEVICE_ERROR An error occured attempting to determine
>the
>+ @retval EFI_DEVICE_ERROR An error occurred attempting to determine
>the
> size of the firmware image currently stored in
> in the firmware device.
>
>--
>2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2019-07-08 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 14:18 [PATCH] FmpDevicePkg: Fix various typos Cœur
2019-07-08 1:21 ` Liming Gao [this message]
2019-07-08 17:08 ` [edk2-devel] " Cœur
2019-07-12 13:11 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4A3672@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox