public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] FmpDevicePkg: Fix various typos
@ 2019-07-05 14:18 Cœur
  2019-07-08  1:21 ` Liming Gao
  0 siblings, 1 reply; 4+ messages in thread
From: Cœur @ 2019-07-05 14:18 UTC (permalink / raw)
  To: devel, liming.gao, michael.d.kinney; +Cc: Antoine Cœur

Fix one typo in FmpDevicePkg.
---
 FmpDevicePkg/FmpDxe/DetectTestKey.c         | 2 +-
 FmpDevicePkg/Include/Library/FmpDeviceLib.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c b/FmpDevicePkg/FmpDxe/DetectTestKey.c
index 52e780dac8..e697a08489 100644
--- a/FmpDevicePkg/FmpDxe/DetectTestKey.c
+++ b/FmpDevicePkg/FmpDxe/DetectTestKey.c
@@ -139,7 +139,7 @@ DetectTestKey (
   }

   //
-  // If test key detected or an error occured checking for the test key, then
+  // If test key detected or an error occurred checking for the test key, then
   // set PcdTestKeyUsed to TRUE.
   //
   if (TestKeyUsed) {
diff --git a/FmpDevicePkg/Include/Library/FmpDeviceLib.h b/FmpDevicePkg/Include/Library/FmpDeviceLib.h
index 708ebca8c5..c435b23030 100644
--- a/FmpDevicePkg/Include/Library/FmpDeviceLib.h
+++ b/FmpDevicePkg/Include/Library/FmpDeviceLib.h
@@ -73,7 +73,7 @@ RegisterFmpInstaller (
   @retval EFI_INVALID_PARAMETER  Size is NULL.
   @retval EFI_UNSUPPORTED        The firmware device does not support reporting
                                  the size of the currently stored firmware image.
-  @retval EFI_DEVICE_ERROR       An error occured attempting to determine the
+  @retval EFI_DEVICE_ERROR       An error occurred attempting to determine the
                                  size of the firmware image currently stored in
                                  in the firmware device.

--
2.20.1 (Apple Git-117)


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] FmpDevicePkg: Fix various typos
  2019-07-05 14:18 [PATCH] FmpDevicePkg: Fix various typos Cœur
@ 2019-07-08  1:21 ` Liming Gao
  2019-07-08 17:08   ` [edk2-devel] " Cœur
  0 siblings, 1 reply; 4+ messages in thread
From: Liming Gao @ 2019-07-08  1:21 UTC (permalink / raw)
  To: coeur@gmx.fr, devel@edk2.groups.io, Kinney, Michael D

Please add Signed-off-by: your name. 

The change is good to me. Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Antoine Cœur [mailto:coeur@gmx.fr]
>Sent: Friday, July 05, 2019 10:18 PM
>To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Kinney,
>Michael D <michael.d.kinney@intel.com>
>Cc: Antoine Cœur <coeur@gmx.fr>
>Subject: [PATCH] FmpDevicePkg: Fix various typos
>
>Fix one typo in FmpDevicePkg.
>---
> FmpDevicePkg/FmpDxe/DetectTestKey.c         | 2 +-
> FmpDevicePkg/Include/Library/FmpDeviceLib.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c
>b/FmpDevicePkg/FmpDxe/DetectTestKey.c
>index 52e780dac8..e697a08489 100644
>--- a/FmpDevicePkg/FmpDxe/DetectTestKey.c
>+++ b/FmpDevicePkg/FmpDxe/DetectTestKey.c
>@@ -139,7 +139,7 @@ DetectTestKey (
>   }
>
>   //
>-  // If test key detected or an error occured checking for the test key, then
>+  // If test key detected or an error occurred checking for the test key, then
>   // set PcdTestKeyUsed to TRUE.
>   //
>   if (TestKeyUsed) {
>diff --git a/FmpDevicePkg/Include/Library/FmpDeviceLib.h
>b/FmpDevicePkg/Include/Library/FmpDeviceLib.h
>index 708ebca8c5..c435b23030 100644
>--- a/FmpDevicePkg/Include/Library/FmpDeviceLib.h
>+++ b/FmpDevicePkg/Include/Library/FmpDeviceLib.h
>@@ -73,7 +73,7 @@ RegisterFmpInstaller (
>   @retval EFI_INVALID_PARAMETER  Size is NULL.
>   @retval EFI_UNSUPPORTED        The firmware device does not support
>reporting
>                                  the size of the currently stored firmware image.
>-  @retval EFI_DEVICE_ERROR       An error occured attempting to determine
>the
>+  @retval EFI_DEVICE_ERROR       An error occurred attempting to determine
>the
>                                  size of the firmware image currently stored in
>                                  in the firmware device.
>
>--
>2.20.1 (Apple Git-117)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] FmpDevicePkg: Fix various typos
  2019-07-08  1:21 ` Liming Gao
@ 2019-07-08 17:08   ` Cœur
  2019-07-12 13:11     ` Liming Gao
  0 siblings, 1 reply; 4+ messages in thread
From: Cœur @ 2019-07-08 17:08 UTC (permalink / raw)
  To: Gao, Liming, devel

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

On Mon, Jul 8, 2019 at 09:21 AM, Liming Gao wrote:

> 
> Please add Signed-off-by: your name.

I'll do that in the future.

Consider it's the following for past emails/patches:

Signed-off-by: Cœur <coeur@gmx.fr>

[-- Attachment #2: Type: text/html, Size: 402 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] FmpDevicePkg: Fix various typos
  2019-07-08 17:08   ` [edk2-devel] " Cœur
@ 2019-07-12 13:11     ` Liming Gao
  0 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2019-07-12 13:11 UTC (permalink / raw)
  To: coeur@gmx.fr, devel@edk2.groups.io

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Push @43622317c67f031f9b2e33c3320f2c89484bd506

From: Cœur [mailto:coeur@gmx.fr]
Sent: Tuesday, July 9, 2019 1:08 AM
To: Gao; Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg: Fix various typos

On Mon, Jul 8, 2019 at 09:21 AM, Liming Gao wrote:
Please add Signed-off-by: your name.

I'll do that in the future.

Consider it's the following for past emails/patches:

Signed-off-by: Cœur <coeur@gmx.fr<mailto:coeur@gmx.fr>>

[-- Attachment #2: Type: text/html, Size: 3820 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-12 13:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-05 14:18 [PATCH] FmpDevicePkg: Fix various typos Cœur
2019-07-08  1:21 ` Liming Gao
2019-07-08 17:08   ` [edk2-devel] " Cœur
2019-07-12 13:11     ` Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox