public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in PosixLike
Date: Mon, 8 Jul 2019 01:53:54 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A3714@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <15AF46F2D8AE7964.4880@groups.io>

Shenglei:
  One minor comments, please update title BaseTools/FMMT to BaseTools.

> >  BaseTools/FMMT: Change FMMT script type in PosixLike
> >  BaseTools/FMMT: Change BfmLib script type in PosixLike
> >  BaseTools/FMMT: Change FCE script type in PosixLike

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao
> Sent: Monday, July 8, 2019 8:27 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>
> Subject: Re: [edk2-devel] [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in PosixLike
> 
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> >-----Original Message-----
> >From: Zhang, Shenglei
> >Sent: Friday, July 05, 2019 10:40 PM
> >To: devel@edk2.groups.io
> >Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> >Subject: [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in
> >PosixLike
> >
> >The existing scripts are PC type, which cause the tools
> >can't be used conveniently like "FMMT -h" in all directories.
> >So change them to UNIX type to fix this problem.
> >
> >Cc: Bob Feng <bob.c.feng@intel.com>
> >Cc: Liming Gao <liming.gao@intel.com>
> >Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> >Shenglei Zhang (3):
> >  BaseTools/FMMT: Change FMMT script type in PosixLike
> >  BaseTools/FMMT: Change BfmLib script type in PosixLike
> >  BaseTools/FMMT: Change FCE script type in PosixLike
> >
> > BaseTools/BinWrappers/PosixLike/BfmLib | 58 +++++++++++++-------------
> > BaseTools/BinWrappers/PosixLike/FCE    | 58 +++++++++++++-------------
> > BaseTools/BinWrappers/PosixLike/FMMT   | 58 +++++++++++++-------------
> > 3 files changed, 87 insertions(+), 87 deletions(-)
> >
> >--
> >2.18.0.windows.1
> 
> 
> 


  parent reply	other threads:[~2019-07-08  1:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 14:40 [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in PosixLike Zhang, Shenglei
2019-07-05 14:40 ` [PATCH 1/3] BaseTools/FMMT: Change FMMT " Zhang, Shenglei
2019-07-05 14:40 ` [PATCH 2/3] BaseTools/FMMT: Change BfmLib " Zhang, Shenglei
2019-07-05 14:40 ` [PATCH 3/3] BaseTools/FMMT: Change FCE " Zhang, Shenglei
2019-07-08  0:26 ` [PATCH 0/3] BaseTools: Change FMMT,BfmLib and " Liming Gao
     [not found] ` <15AF46F2D8AE7964.4880@groups.io>
2019-07-08  1:53   ` Liming Gao [this message]
2019-07-08  2:18 ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4A3714@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox