From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Sun, 07 Jul 2019 19:06:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jul 2019 19:06:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,464,1557212400"; d="scan'208";a="364083624" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 07 Jul 2019 19:06:50 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 7 Jul 2019 19:06:50 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 7 Jul 2019 19:06:49 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.240]) with mapi id 14.03.0439.000; Mon, 8 Jul 2019 10:06:48 +0800 From: "Liming Gao" To: "Feng, Bob C" , "devel@edk2.groups.io" Subject: Re: [Patch 1/1] BaseTools: Fixed the issue of the CFlag for compile PcdValueInit.c Thread-Topic: [Patch 1/1] BaseTools: Fixed the issue of the CFlag for compile PcdValueInit.c Thread-Index: AQHVL/I3yZl2dj/3tUqGHblClJO7gqbAA6oQ Date: Mon, 8 Jul 2019 02:06:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A3768@SHSMSX104.ccr.corp.intel.com> References: <20190701094851.19940-1-bob.c.feng@intel.com> In-Reply-To: <20190701094851.19940-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTI3MWYyZGQtMzEwOC00OGFjLWI0NGItNTEwYzhmOTFlNzI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUXBMSDZYRXNDY0c0ZjBCczV3clJmeXhNRFk1SVUxQUF2XC9ZRHJocFBSc3FiQnloeVVkbGRCOTlTMysrRnFEVk8ifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Feng, Bob C > Sent: Monday, July 1, 2019 5:49 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [Patch 1/1] BaseTools: Fixed the issue of the CFlag for compile = PcdValueInit.c >=20 > This issue happens when using Structured PCD. > Build tool use set to store the cflags for compile PcdValueInit.c, > that is the order of cflags is disorder. >=20 > This patch make -U, /U flags appear before -D, /D >=20 > Cc: Liming Gao > Signed-off-by: Bob Feng > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTool= s/Source/Python/Workspace/DscBuildData.py > index 9f65ad54257d..985f8775259d 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -2666,11 +2666,12 @@ class DscBuildData(PlatformBuildClassObject): > if len(ArchBuildOptions.keys()) =3D=3D 1: > BuildOptions['COMMON'] |=3D (list(ArchBuildOptions.value= s())[0]) > elif len(ArchBuildOptions.keys()) > 1: > CommonBuildOptions =3D reduce(lambda x,y: x&y, ArchBuild= Options.values()) > BuildOptions['COMMON'] |=3D CommonBuildOptions > - ValueList =3D list(BuildOptions['COMMON']) > + ValueList =3D [item for item in BuildOptions['COMMON'] if it= em.startswith((r"/U","-U"))] > + ValueList.extend([item for item in BuildOptions['COMMON'] if= item.startswith((r"/D", "-D"))]) > CC_FLAGS +=3D " ".join(ValueList) > MakeApp +=3D CC_FLAGS >=20 > if sys.platform =3D=3D "win32": > MakeApp =3D MakeApp + PcdMakefileEnd > -- > 2.20.1.windows.1