From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 10 Jul 2019 00:44:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 00:44:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,473,1557212400"; d="scan'208";a="192958634" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 10 Jul 2019 00:44:02 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 00:44:01 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 10 Jul 2019 00:44:01 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 10 Jul 2019 00:44:01 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.60]) with mapi id 14.03.0439.000; Wed, 10 Jul 2019 15:43:59 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Wang, Jian J" CC: Leif Lindholm , "Kinney, Michael D" Subject: Re: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands Thread-Topic: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands Thread-Index: AQHVNuYb5/neN8IpaU+3lCmKoJjAkKbDd/KQ Date: Wed, 10 Jul 2019 07:43:59 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A5056@SHSMSX104.ccr.corp.intel.com> References: <20190710060955.7672-1-jian.j.wang@intel.com> <20190710060955.7672-2-jian.j.wang@intel.com> In-Reply-To: <20190710060955.7672-2-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jian: >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Wang, Jian J >Sent: Wednesday, July 10, 2019 2:10 PM >To: devel@edk2.groups.io >Cc: Leif Lindholm ; Kinney, Michael D >; Gao, Liming >Subject: [edk2-devel] [ PATCH v2 1/2] Readme.md: add submodule policy and >clone commands > >> v2: update wording per Leif's and others' comments > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1910 > >A section 'Submodules' is added to clarify the submodule policy >in edk2 repo. Git commands are also added to show the correct >way to clone submodule repos, in which '--recursive' is removed >because it's not needed but recommended in other document. > >Related commits: >Openssl-1.1.1b upgrade: acfb90911840c38a0beb9bcfe0065668244d2b4d >berkeley-softfloat-3: 3cc57695df5a6e8c65fb46b993836c315cabf49d > >Cc: Leif Lindholm >Cc: Michael D Kinney >Cc: Liming Gao >Signed-off-by: Jian J Wang >--- > Readme.md | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > >diff --git a/Readme.md b/Readme.md >index e564c6c09b..c475468655 100644 >--- a/Readme.md >+++ b/Readme.md >@@ -143,3 +143,31 @@ Signed-off-by: Contributor Name > > the change. Each line should be less than ~70 characters. > * `Signed-off-by` is the contributor's signature identifying them > by their real/legal name and their email address. >+ >+# Submodules >+ >+As a general policy, submodule chain should be avoided in EDK II repo >+as possible as we can. Currently EDK II contains two submodules Here, I understand to avoid the child submodule, and the root submodule is= allowed.=20 Besides, there is two spaces between EDK II contains. Please take care.= =20 >+ >+- CryptoPkg/Library/OpensslLib/openssl >+- ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 >+ >+The latter one is actually required by previous one. It's inevitable >+in openssl-1.1.1 (since stable201905) for floating point parameter >+conversion, but should be dropped once there's no such need in future >+release of openssl. >+ >+To get a full, buildable EDK II repository, use following two steps >+of git command >+ >+``` >+$ git clone https://github.com/tianocore/edk2.git >+$ git submodule update --init >+``` >+ Please also give the update command for submodule.=20 Thanks Liming >+Note: When cloning submodule repos, '--recursive' option is not >+recommended. EDK II itself will not use any code/feature from >+submodules in above submodules. So using '--recursive' adds a >+dependency on being able to reach servers we do not actually want >+any code from, as well as needlessly downloading code we will not >+use. >-- >2.17.1.windows.2 > > >