From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 16 Jul 2019 18:00:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2019 18:00:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,272,1559545200"; d="scan'208";a="170098112" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 16 Jul 2019 18:00:16 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jul 2019 18:00:16 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jul 2019 18:00:15 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.134]) with mapi id 14.03.0439.000; Wed, 17 Jul 2019 09:00:14 +0800 From: "Liming Gao" To: Laszlo Ersek , edk2-devel-groups-io CC: "Kinney, Michael D" , =?utf-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= , "Gao, Zhichao" Subject: Re: [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks Thread-Topic: [PATCH] MdePkg/BaseLib: Base64Decode(): don't declare variables in nested blocks Thread-Index: AQHVPCojhne62UucB0KRO/FfesnckKbN/Z0A Date: Wed, 17 Jul 2019 01:00:13 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A94A8@SHSMSX104.ccr.corp.intel.com> References: <20190716225926.19732-1-lersek@redhat.com> In-Reply-To: <20190716225926.19732-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzk5YWUxOWEtN2UwNS00ZmU0LThkZDEtMmVjMWJjYTQ3NzI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMURnalBPbEZucndOcmJKMVZ2TTUreXIrZ1Eyek9NeFY5WExWejFGSzBHMDlBR2lTVFBMWU1PNUNZNEZTM0FKQyJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 UmV2aWV3ZWQtYnk6IExpbWluZyBHYW8gPGxpbWluZy5nYW9AaW50ZWwuY29tPg0KDQo+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IExhc3psbyBFcnNlayBbbWFpbHRvOmxlcnNl a0ByZWRoYXQuY29tXQ0KPiBTZW50OiBXZWRuZXNkYXksIEp1bHkgMTcsIDIwMTkgNjo1OSBBTQ0K PiBUbzogZWRrMi1kZXZlbC1ncm91cHMtaW8gPGRldmVsQGVkazIuZ3JvdXBzLmlvPg0KPiBDYzog R2FvLCBMaW1pbmcgPGxpbWluZy5nYW9AaW50ZWwuY29tPjsgS2lubmV5LCBNaWNoYWVsIEQgPG1p Y2hhZWwuZC5raW5uZXlAaW50ZWwuY29tPjsgUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kNCj4gPHBo aWxtZEByZWRoYXQuY29tPjsgR2FvLCBaaGljaGFvIDx6aGljaGFvLmdhb0BpbnRlbC5jb20+DQo+ IFN1YmplY3Q6IFtQQVRDSF0gTWRlUGtnL0Jhc2VMaWI6IEJhc2U2NERlY29kZSgpOiBkb24ndCBk ZWNsYXJlIHZhcmlhYmxlcyBpbiBuZXN0ZWQgYmxvY2tzDQo+IA0KPiBUaGUgRURLIElJIEMgQ29k aW5nIFN0YW5kYXJkcyBTcGVjaWZpY2F0aW9uICh2Mi4yMCkgc3Ryb25nbHkgZGlzY291cmFnZXMN Cj4gdmFyaWFibGUgZGVjbGFyYXRpb25zIGluIG5lc3RlZCBibG9jayBzY29wZToNCj4gDQo+IDUg ICAgICAgU291cmNlIEZpbGVzDQo+IDUuNCAgICAgQ29kZSBGaWxlIFN0cnVjdHVyZQ0KPiA1LjQu MSAgIFNjb3BpbmcgUnVsZXMNCj4gNS40LjEuMSBTY29wZQ0KPiANCj4gPiBCbG9jayAobG9jYWwp IFNjb3BlDQo+ID4NCj4gPiBbLi4uXQ0KPiA+DQo+ID4gRGF0YSBkZWNsYXJhdGlvbnMgbWF5IGZv bGxvdyB0aGUgb3BlbmluZyBicmFjZSBvZiBhIGNvbXBvdW5kIHN0YXRlbWVudCwNCj4gPiByZWdh cmRsZXNzIG9mIG5lc3RpbmcgZGVwdGgsIGFuZCBiZWZvcmUgYW55IGNvZGUgZ2VuZXJhdGluZyBz dGF0ZW1lbnRzDQo+ID4gaGF2ZSBiZWVuIGVudGVyZWQuIE90aGVyIHRoYW4gYXQgdGhlIG91dGVy bW9zdCBibG9jayBvZiBhIGZ1bmN0aW9uIGJvZHksDQo+ID4gdGhpcyB0eXBlIG9mIGRlY2xhcmF0 aW9uIGlzIHN0cm9uZ2x5IGRpc2NvdXJhZ2VkLg0KPiANCj4gSG9pc3Qgc3VjaCB2YXJpYWJsZSBk ZWNsYXJhdGlvbnMgaW4gQmFzZTY0RGVjb2RlKCkgdG8gdGhlIG91dGVybW9zdA0KPiBmdW5jdGlv biBzY29wZS4NCj4gDQo+IENjOiBMaW1pbmcgR2FvIDxsaW1pbmcuZ2FvQGludGVsLmNvbT4NCj4g Q2M6IE1pY2hhZWwgRCBLaW5uZXkgPG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29tPg0KPiBDYzog UGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPHBoaWxtZEByZWRoYXQuY29tPg0KPiBDYzogWmhpY2hh byBHYW8gPHpoaWNoYW8uZ2FvQGludGVsLmNvbT4NCj4gRml4ZXM6IDM1ZTI0MmI2OThjZGM2MjA1 ZTk5YTZkNmExODhiZjI3ZmVjZjlmYjQNCj4gUmVmOiBodHRwczovL2J1Z3ppbGxhLnRpYW5vY29y ZS5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODANCj4gUmVwb3J0ZWQtYnk6IFpoaWNoYW8gR2FvIDx6 aGljaGFvLmdhb0BpbnRlbC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IExhc3psbyBFcnNlayA8bGVy c2VrQHJlZGhhdC5jb20+DQo+IC0tLQ0KPiANCj4gTm90ZXM6DQo+ICAgICBSZXBvOiAgIGh0dHBz Oi8vZ2l0aHViLmNvbS9sZXJzZWsvZWRrMi5naXQNCj4gICAgIEJyYW5jaDogYjY0X2RlY29kZV9u b19uZXN0ZWRfYnoxOTgwDQo+IA0KPiAgTWRlUGtnL0xpYnJhcnkvQmFzZUxpYi9TdHJpbmcuYyB8 IDcgKysrLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv bnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9NZGVQa2cvTGlicmFyeS9CYXNlTGliL1N0cmluZy5j IGIvTWRlUGtnL0xpYnJhcnkvQmFzZUxpYi9TdHJpbmcuYw0KPiBpbmRleCA2MTk4Y2NiYzk2NzIu LjQ1MTk4MzczZjI1YyAxMDA2NDQNCj4gLS0tIGEvTWRlUGtnL0xpYnJhcnkvQmFzZUxpYi9TdHJp bmcuYw0KPiArKysgYi9NZGVQa2cvTGlicmFyeS9CYXNlTGliL1N0cmluZy5jDQo+IEBAIC0xOTc4 LDYgKzE5NzgsOSBAQCBCYXNlNjREZWNvZGUgKA0KPiAgICBVSU5UMzIgIEFjY3VtdWxhdG9yOw0K PiAgICBVSU5UTiAgIE9yaWdpbmFsRGVzdGluYXRpb25TaXplOw0KPiAgICBVSU5UTiAgIFNvdXJj ZUluZGV4Ow0KPiArICBDSEFSOCAgIFNvdXJjZUNoYXI7DQo+ICsgIFVJTlQzMiAgQmFzZTY0VmFs dWU7DQo+ICsgIFVJTlQ4ICAgRGVzdGluYXRpb25PY3RldDsNCj4gDQo+ICAgIGlmIChEZXN0aW5h dGlvblNpemUgPT0gTlVMTCkgew0KPiAgICAgIHJldHVybiBSRVRVUk5fSU5WQUxJRF9QQVJBTUVU RVI7DQo+IEBAIC0yMDU0LDEwICsyMDU3LDYgQEAgQmFzZTY0RGVjb2RlICgNCj4gICAgLy8gRGVj b2RpbmcgbG9vcC4NCj4gICAgLy8NCj4gICAgZm9yIChTb3VyY2VJbmRleCA9IDA7IFNvdXJjZUlu ZGV4IDwgU291cmNlU2l6ZTsgU291cmNlSW5kZXgrKykgew0KPiAtICAgIENIQVI4ICBTb3VyY2VD aGFyOw0KPiAtICAgIFVJTlQzMiBCYXNlNjRWYWx1ZTsNCj4gLSAgICBVSU5UOCAgRGVzdGluYXRp b25PY3RldDsNCj4gLQ0KPiAgICAgIFNvdXJjZUNoYXIgPSBTb3VyY2VbU291cmNlSW5kZXhdOw0K PiANCj4gICAgICAvLw0KPiAtLQ0KPiAyLjE5LjEuMy5nMzAyNDdhYTVkMjAxDQoNCg==