From: "Liming Gao" <liming.gao@intel.com>
To: Rebecca Cran <rebecca@bsdio.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"afish@apple.com" <afish@apple.com>,
"Fan, ZhijuX" <zhijux.fan@intel.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
Date: Wed, 17 Jul 2019 02:56:49 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A9706@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190716165538.57960-1-rebecca@bsdio.com>
Rebecca:
The change is good. Reviewed-by: Liming Gao <liming.gao@intel.com> for 1-4, and 6.
For patch 5, I see Leif sends another version update. I will give the comments on his change.
Thanks
Liming
> -----Original Message-----
> From: Rebecca Cran [mailto:rebecca@bsdio.com]
> Sent: Wednesday, July 17, 2019 12:56 AM
> To: devel@edk2.groups.io; lersek@redhat.com; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; afish@apple.com; Fan, ZhijuX <zhijux.fan@intel.com>; leif.lindholm@linaro.org
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Subject: [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
>
> This is a (very minor) optimization: `pwd` runs the command (even as a
> built-in), whereas $PWD simply evaluates the value of the variable.
>
> ALso, modern scripts should generally use $(...) to run commands,
> instead of `...`.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> edksetup.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/edksetup.sh b/edksetup.sh
> index 12a3e26a67..ab58fe4a6e 100755
> --- a/edksetup.sh
> +++ b/edksetup.sh
> @@ -71,7 +71,7 @@ function SetWorkspace()
> #
> # Set $WORKSPACE
> #
> - export WORKSPACE=`pwd`
> + export WORKSPACE=$PWD
> return 0
> }
>
> --
> 2.22.0
next prev parent reply other threads:[~2019-07-17 2:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 16:55 [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command rebecca
2019-07-16 16:55 ` [PATCH v4 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh' rebecca
2019-07-16 16:55 ` [PATCH v4 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed rebecca
2019-07-16 16:55 ` [PATCH v4 4/6] edksetup.sh: remove redundant -?, -h and --help in options parsing rebecca
2019-07-16 16:55 ` [PATCH v4 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions rebecca
2019-07-16 18:48 ` Laszlo Ersek
2019-07-16 16:55 ` [PATCH v4 6/6] edksetup.sh: Add quotes and explicit checks in test statements rebecca
2019-07-17 2:56 ` Liming Gao [this message]
2019-07-22 22:16 ` [edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command Laszlo Ersek
2019-07-22 22:52 ` rebecca
2019-07-23 8:51 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4A9706@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox