From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by groups.io with SMTP; Tue, 16 Jul 2019 19:56:55 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
  by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2019 19:56:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,272,1559545200"; 
   d="scan'208";a="366870483"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by fmsmga006.fm.intel.com with ESMTP; 16 Jul 2019 19:56:55 -0700
Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 16 Jul 2019 19:56:55 -0700
Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Tue, 16 Jul 2019 19:56:51 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5
 via Frontend Transport; Tue, 16 Jul 2019 19:56:51 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.134]) with mapi id 14.03.0439.000;
 Wed, 17 Jul 2019 10:56:50 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: Rebecca Cran <rebecca@bsdio.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>, "lersek@redhat.com" <lersek@redhat.com>, "Feng, Bob
 C" <bob.c.feng@intel.com>, "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"afish@apple.com" <afish@apple.com>, "Fan, ZhijuX" <zhijux.fan@intel.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
Thread-Topic: [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of
 executing pwd command
Thread-Index: AQHVO/dP8JQrLVbunkeyag5ZkhnmWKbOHigA
Date: Wed, 17 Jul 2019 02:56:49 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A9706@SHSMSX104.ccr.corp.intel.com>
References: <20190716165538.57960-1-rebecca@bsdio.com>
In-Reply-To: <20190716165538.57960-1-rebecca@bsdio.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGVjZTg3MTQtYjY1OC00MmI4LTliN2UtNjg4YjlhNmQ1ZDg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidG9MbVpSSFwvemN1YVNaczhGZk8xcUFMMGpmTGRWQTJNNm1BV3FPU3lFeldzMXE0MkJRdVN6K2FGRmpUREgxWTcifQ==
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Rebecca:
  The change is good. Reviewed-by: Liming Gao <liming.gao@intel.com> for 1-=
4, and 6.=20
 =20
  For patch 5, I see Leif sends another version update. I will give the com=
ments on his change.=20

Thanks
Liming
> -----Original Message-----
> From: Rebecca Cran [mailto:rebecca@bsdio.com]
> Sent: Wednesday, July 17, 2019 12:56 AM
> To: devel@edk2.groups.io; lersek@redhat.com; Feng, Bob C <bob.c.feng@inte=
l.com>; Gao, Liming <liming.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; afish@apple.com; Fan, ZhijuX <zhi=
jux.fan@intel.com>; leif.lindholm@linaro.org
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Subject: [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of ex=
ecuting pwd command
>=20
> This is a (very minor) optimization: `pwd` runs the command (even as a
> built-in), whereas $PWD simply evaluates the value of the variable.
>=20
> ALso, modern scripts should generally use $(...) to run commands,
> instead of `...`.
>=20
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  edksetup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/edksetup.sh b/edksetup.sh
> index 12a3e26a67..ab58fe4a6e 100755
> --- a/edksetup.sh
> +++ b/edksetup.sh
> @@ -71,7 +71,7 @@ function SetWorkspace()
>    #
>    # Set $WORKSPACE
>    #
> -  export WORKSPACE=3D`pwd`
> +  export WORKSPACE=3D$PWD
>    return 0
>  }
>=20
> --
> 2.22.0