From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Sun, Zailiang" <zailiang.sun@intel.com>,
"Qian, Yi" <yi.qian@intel.com>, Gary Lin <glin@suse.com>
Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD
Date: Fri, 19 Jul 2019 06:40:34 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC568@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9D7900A@ORSMSX113.amr.corp.intel.com>
Mike:
Yes. Wiki https://github.com/lgao4/edk2/wiki/StructurePcd-Enable-Steps shows the usage of the different default store.
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Michael D Kinney
>Sent: Friday, July 19, 2019 2:05 PM
>To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Kinney,
>Michael D <michael.d.kinney@intel.com>
>Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>; Gary
>Lin <glin@suse.com>
>Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg:
>Convert use of FCE tool to Structured PCD
>
>Liming,
>
>Thanks for the feedback. I have made both changes
>in the V2 version of the series.
>
>We should show some examples of inheriting defaults
>from STANDARD defaults.
>
>Mike
>
>> -----Original Message-----
>> From: Gao, Liming
>> Sent: Thursday, July 18, 2019 8:41 PM
>> To: devel@edk2.groups.io; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi
>> <yi.qian@intel.com>; Gary Lin <glin@suse.com>
>> Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5]
>> Vlv2TbltDevicePkg: Convert use of FCE tool to Structured
>> PCD
>>
>> Mike:
>> I have two comments here.
>> 1. VarStore is updated to EfiVarStore. So,
>> HiiConfigAccess ExtractConfig() and RouteConfig() can be
>> updated to directly return UNSUPPORTED, they are not
>> used any more.
>> 2. DSC doesn't need to include PlatformSetupDefaults.dsc
>> twice. By default, MANUFACTURING setting will be
>> inherited from STANDARD. Only different default setting
>> is required to be specified. For your case,
>> MANUFACTURING default is same to STANDARD. So, you only
>> need to include the default setting for STANDARD only.
>>
>> [PcdsDynamicExHii.common.DEFAULT.STANDARD]
>> !include Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc
>>
>> [PcdsDynamicExHii.common.DEFAULT.MANUFACTURING] # can
>> be removed.
>> !include Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc
>> # can be removed.
>>
>> Thanks
>> Liming
next prev parent reply other threads:[~2019-07-19 6:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 23:00 [edk2-platforms Patch 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Michael D Kinney
2019-07-18 23:00 ` [edk2-platforms Patch 1/5] Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection Michael D Kinney
2019-07-19 3:18 ` [edk2-devel] " Sun, Zailiang
2019-07-18 23:00 ` [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Michael D Kinney
2019-07-19 3:18 ` [edk2-devel] " Sun, Zailiang
2019-07-19 3:40 ` Liming Gao
2019-07-19 6:04 ` Michael D Kinney
2019-07-19 6:40 ` Liming Gao [this message]
2019-07-19 15:50 ` Michael D Kinney
2019-07-20 15:11 ` Liming Gao
2019-07-18 23:00 ` [edk2-platforms Patch 3/5] Vlv2TbltDevicePkg: Remove Linux/GCC specific DSC/FDF files Michael D Kinney
2019-07-19 3:19 ` Sun, Zailiang
2019-07-18 23:00 ` [edk2-platforms Patch 4/5] Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to Python Michael D Kinney
2019-07-19 3:19 ` [edk2-devel] " Sun, Zailiang
2019-07-18 23:00 ` [edk2-platforms Patch 5/5] Vlv2Tbl2DevicePkg: Convert BAT/sh Build " Michael D Kinney
2019-07-18 23:03 ` [edk2-devel] [edk2-platforms Patch 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC568@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox