From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Thu, 18 Jul 2019 23:40:37 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 23:40:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,281,1559545200"; d="scan'208";a="176218772" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 18 Jul 2019 23:40:36 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 23:40:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.232]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 14:40:34 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Sun, Zailiang" , "Qian, Yi" , Gary Lin Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Thread-Topic: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Thread-Index: AQHVPbys3EU6tiLj80yxGIZOeyhqxqbRSauA//+kdICAAI/d4A== Date: Fri, 19 Jul 2019 06:40:34 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC568@SHSMSX104.ccr.corp.intel.com> References: <20190718230017.14852-1-michael.d.kinney@intel.com> <20190718230017.14852-3-michael.d.kinney@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC38E@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike: Yes. Wiki https://github.com/lgao4/edk2/wiki/StructurePcd-Enable-Steps sh= ows the usage of the different default store.=20 >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Michael D Kinney >Sent: Friday, July 19, 2019 2:05 PM >To: Gao, Liming ; devel@edk2.groups.io; Kinney, >Michael D >Cc: Sun, Zailiang ; Qian, Yi ; = Gary >Lin >Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: >Convert use of FCE tool to Structured PCD > >Liming, > >Thanks for the feedback. I have made both changes >in the V2 version of the series. > >We should show some examples of inheriting defaults >from STANDARD defaults. > >Mike > >> -----Original Message----- >> From: Gao, Liming >> Sent: Thursday, July 18, 2019 8:41 PM >> To: devel@edk2.groups.io; Kinney, Michael D >> >> Cc: Sun, Zailiang ; Qian, Yi >> ; Gary Lin >> Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] >> Vlv2TbltDevicePkg: Convert use of FCE tool to Structured >> PCD >> >> Mike: >> I have two comments here. >> 1. VarStore is updated to EfiVarStore. So, >> HiiConfigAccess ExtractConfig() and RouteConfig() can be >> updated to directly return UNSUPPORTED, they are not >> used any more. >> 2. DSC doesn't need to include PlatformSetupDefaults.dsc >> twice. By default, MANUFACTURING setting will be >> inherited from STANDARD. Only different default setting >> is required to be specified. For your case, >> MANUFACTURING default is same to STANDARD. So, you only >> need to include the default setting for STANDARD only. >> >> [PcdsDynamicExHii.common.DEFAULT.STANDARD] >> !include Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc >> >> [PcdsDynamicExHii.common.DEFAULT.MANUFACTURING] # can >> be removed. >> !include Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc >> # can be removed. >> >> Thanks >> Liming