From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms Patch V2 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences
Date: Fri, 19 Jul 2019 06:42:06 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC57B@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190719060247.10132-1-michael.d.kinney@intel.com>
Mike:
The update patch is good. Reviewed-by: Liming Gao <liming.gao@intel.com> for Patch 2.
Thanks
Liming
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Michael D Kinney
>Sent: Friday, July 19, 2019 2:03 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [edk2-platforms Patch V2 0/5] Vlv2Tbl2DevicePkg:
>Remove Linux/Windows differences
>
>New in V2
>----------
>* Remove MANUFACTURING defaults from DSC file. They are the same as
>STANDARD
> defaults, so there is not need to add a MANUFACTURING default section
>unless
> there are differences.
>* Update PlatformSetupDxe to return EFI_UNSUPPORTED from the
>RouteConfig() and
> ExtractConfig() services of the HII_CONFIG_ACCESS_PROTOCOL.
>
>Branch for review:
>
>https://github.com/mdkinney/edk2-
>platforms/tree/Bug_xxx_Vlv2_Remove_FCE_BAT_sh_V2
>
>Remove all BAT/sh scripts and use OS independent python scripts for
>PREBULD and
>POSTBUILD operations and use standard EDK II build command to build
>MinnowMax
>FW images and capsules.
>
>The use of FCE has also been removed and replaced with a Structured PCD.
>The
>default values for Setup forms are now in the file PlatformSetupDefaults.dsc.
>
>A regression bug introduced by a recent commit that broke the detection of
>the
>BOOT_ON_FLASH_UPDATE boot mode has also been fixed. Capsules are
>detected and
>processed correctly again.
>
>Michael D Kinney (5):
> Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection
> Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD
> Vlv2TbltDevicePkg: Remove Linux/GCC specific DSC/FDF files
> Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to Python
> Vlv2Tbl2DevicePkg: Convert BAT/sh Build scripts to Python
>
> Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe | Bin 499712 -> 0 bytes
> .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat | 118 --
> .../Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 100 --
> Platform/Intel/Vlv2TbltDevicePkg/FCE.exe | Bin 632832 -> 0 bytes
> .../Capsule/GenerateCapsule/GenCapsuleAll.bat | 35 -
> .../Capsule/GenerateCapsule/GenCapsuleAll.py | 397 +++++
> .../Capsule/GenerateCapsule/GenCapsuleAll.sh | 33 -
> .../GenerateCapsule/GenCapsuleMinnowMax.bat | 131 --
> .../GenerateCapsule/GenCapsuleMinnowMax.sh | 59 -
> .../GenCapsuleMinnowMaxRelease.bat | 131 --
> .../GenCapsuleMinnowMaxRelease.sh | 64 -
> .../GenerateCapsule/GenCapsuleSampleColor.bat | 137 --
> .../GenerateCapsule/GenCapsuleSampleColor.sh | 70 -
> .../Feature/Capsule/GenerateCapsule/Lvfs.ddf | 14 -
> .../LvfsGenCapsuleMinnowMax.bat | 139 --
> .../LvfsGenCapsuleMinnowMaxRelease.bat | 139 --
> .../LvfsGenCapsuleSampleColor.bat | 145 --
> .../GenerateCapsule/template.metainfo.xml | 27 -
> .../SystemFirmwareDescriptor.aslc | 83 --
> .../SystemFirmwareDescriptor.inf | 40 -
> .../SystemFirmwareDescriptorPei.c | 60 -
> .../SystemFirmwareUpdateConfig.ini | 66 -
> .../SystemFirmwareUpdateConfigGcc.ini | 66 -
> .../Vlv2TbltDevicePkg/PlatformCapsule.dsc | 39 -
> .../Vlv2TbltDevicePkg/PlatformCapsule.fdf | 52 -
> .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc | 38 -
> .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf | 52 -
> .../PlatformInitPei/PlatformEarlyInit.c | 40 +-
> .../PlatformInitPei/PlatformInitPei.inf | 2 +
> .../Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 92 +-
> .../Vlv2TbltDevicePkg/PlatformPei/Platform.c | 6 +
> .../Vlv2TbltDevicePkg/PlatformPei/Platform.h | 17 +
> .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 12 +
> .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 52 +-
> .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 914 ------------
> .../Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 1272 ----------------
> .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1289 -----------------
> .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 88 +-
> .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 86 +-
> .../PlatformSetupDefaults.dsc | 130 ++
> .../PlatformSetupDxe/PlatformSetupDxe.c | 145 +-
> .../PlatformSetupDxe/Vfr.vfr | 17 +-
> Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py | 348 +++++
> Platform/Intel/Vlv2TbltDevicePkg/Readme.md | 62 +-
> .../Stitch/Gcc/NvStorageFtwSpare.bin | Bin 262144 -> 0 bytes
> .../Stitch/Gcc/NvStorageFtwWorking.bin | Bin 8192 -> 0 bytes
> .../Stitch/Gcc/NvStorageVariable.bin | Bin 253952 -> 0 bytes
> Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat | 322 ----
> Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 235 ---
> 49 files changed, 1227 insertions(+), 6137 deletions(-)
> delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe
> delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.bat
> delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FCE.exe
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleAll.bat
> create mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleAll.py
> delete mode 100755
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleAll.sh
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleMinnowMax.bat
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleMinnowMax.sh
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleMinnowMaxRelease.bat
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleMinnowMaxRelease.sh
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleSampleColor.bat
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa
>psuleSampleColor.sh
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/Lvfs.dd
>f
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/LvfsGe
>nCapsuleMinnowMax.bat
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/LvfsGe
>nCapsuleMinnowMaxRelease.bat
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/LvfsGe
>nCapsuleSampleColor.bat
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/templa
>te.metainfo.xml
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescript
>or/SystemFirmwareDescriptor.aslc
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescript
>or/SystemFirmwareDescriptor.inf
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescript
>or/SystemFirmwareDescriptorPei.c
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareUpdateC
>onfig/SystemFirmwareUpdateConfig.ini
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareUpdateC
>onfig/SystemFirmwareUpdateConfigGcc.ini
> delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.dsc
> delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.fdf
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf
> delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> create mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc
> create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageFtwSpare.bin
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageFtwWorking.bin
> delete mode 100644
>Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageVariable.bin
> delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat
> delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
>
>--
>2.21.0.windows.1
>
>
>
prev parent reply other threads:[~2019-07-19 6:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 6:02 [edk2-platforms Patch V2 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Michael D Kinney
2019-07-19 6:02 ` [edk2-platforms Patch V2 1/5] Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection Michael D Kinney
2019-07-19 6:02 ` [edk2-platforms Patch V2 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Michael D Kinney
2019-07-19 6:02 ` [edk2-platforms Patch V2 3/5] Vlv2TbltDevicePkg: Remove Linux/GCC specific DSC/FDF files Michael D Kinney
2019-07-19 6:02 ` [edk2-platforms Patch V2 4/5] Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to Python Michael D Kinney
2019-07-19 6:02 ` [edk2-platforms Patch V2 5/5] Vlv2Tbl2DevicePkg: Convert BAT/sh Build " Michael D Kinney
2019-07-22 4:08 ` [edk2-devel] " Gary Lin
2019-07-22 17:24 ` Michael D Kinney
2019-07-19 6:42 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC57B@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox