From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 18 Jul 2019 23:42:09 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 23:42:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,281,1559545200"; d="scan'208";a="159022081" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 18 Jul 2019 23:42:09 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 23:42:08 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 23:42:08 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 14:42:07 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-platforms Patch V2 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Thread-Topic: [edk2-devel] [edk2-platforms Patch V2 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences Thread-Index: AQHVPfecybR+vr7rtUylIQYKVAT5dabRfdgA Date: Fri, 19 Jul 2019 06:42:06 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC57B@SHSMSX104.ccr.corp.intel.com> References: <20190719060247.10132-1-michael.d.kinney@intel.com> In-Reply-To: <20190719060247.10132-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike: The update patch is good. Reviewed-by: Liming Gao = for Patch 2.=20 Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Michael D Kinney >Sent: Friday, July 19, 2019 2:03 PM >To: devel@edk2.groups.io >Subject: [edk2-devel] [edk2-platforms Patch V2 0/5] Vlv2Tbl2DevicePkg: >Remove Linux/Windows differences > >New in V2 >---------- >* Remove MANUFACTURING defaults from DSC file. They are the same as >STANDARD > defaults, so there is not need to add a MANUFACTURING default section >unless > there are differences. >* Update PlatformSetupDxe to return EFI_UNSUPPORTED from the >RouteConfig() and > ExtractConfig() services of the HII_CONFIG_ACCESS_PROTOCOL. > >Branch for review: > >https://github.com/mdkinney/edk2- >platforms/tree/Bug_xxx_Vlv2_Remove_FCE_BAT_sh_V2 > >Remove all BAT/sh scripts and use OS independent python scripts for >PREBULD and >POSTBUILD operations and use standard EDK II build command to build >MinnowMax >FW images and capsules. > >The use of FCE has also been removed and replaced with a Structured PCD. >The >default values for Setup forms are now in the file PlatformSetupDefaults.= dsc. > >A regression bug introduced by a recent commit that broke the detection o= f >the >BOOT_ON_FLASH_UPDATE boot mode has also been fixed. Capsules are >detected and >processed correctly again. > >Michael D Kinney (5): > Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection > Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD > Vlv2TbltDevicePkg: Remove Linux/GCC specific DSC/FDF files > Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to Python > Vlv2Tbl2DevicePkg: Convert BAT/sh Build scripts to Python > > Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe | Bin 499712 -> 0 bytes > .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat | 118 -- > .../Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 100 -- > Platform/Intel/Vlv2TbltDevicePkg/FCE.exe | Bin 632832 -> 0 bytes > .../Capsule/GenerateCapsule/GenCapsuleAll.bat | 35 - > .../Capsule/GenerateCapsule/GenCapsuleAll.py | 397 +++++ > .../Capsule/GenerateCapsule/GenCapsuleAll.sh | 33 - > .../GenerateCapsule/GenCapsuleMinnowMax.bat | 131 -- > .../GenerateCapsule/GenCapsuleMinnowMax.sh | 59 - > .../GenCapsuleMinnowMaxRelease.bat | 131 -- > .../GenCapsuleMinnowMaxRelease.sh | 64 - > .../GenerateCapsule/GenCapsuleSampleColor.bat | 137 -- > .../GenerateCapsule/GenCapsuleSampleColor.sh | 70 - > .../Feature/Capsule/GenerateCapsule/Lvfs.ddf | 14 - > .../LvfsGenCapsuleMinnowMax.bat | 139 -- > .../LvfsGenCapsuleMinnowMaxRelease.bat | 139 -- > .../LvfsGenCapsuleSampleColor.bat | 145 -- > .../GenerateCapsule/template.metainfo.xml | 27 - > .../SystemFirmwareDescriptor.aslc | 83 -- > .../SystemFirmwareDescriptor.inf | 40 - > .../SystemFirmwareDescriptorPei.c | 60 - > .../SystemFirmwareUpdateConfig.ini | 66 - > .../SystemFirmwareUpdateConfigGcc.ini | 66 - > .../Vlv2TbltDevicePkg/PlatformCapsule.dsc | 39 - > .../Vlv2TbltDevicePkg/PlatformCapsule.fdf | 52 - > .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc | 38 - > .../Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf | 52 - > .../PlatformInitPei/PlatformEarlyInit.c | 40 +- > .../PlatformInitPei/PlatformInitPei.inf | 2 + > .../Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 92 +- > .../Vlv2TbltDevicePkg/PlatformPei/Platform.c | 6 + > .../Vlv2TbltDevicePkg/PlatformPei/Platform.h | 17 + > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 12 + > .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 52 +- > .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 914 ------------ > .../Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 1272 ---------------- > .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1289 ----------------- > .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 88 +- > .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 86 +- > .../PlatformSetupDefaults.dsc | 130 ++ > .../PlatformSetupDxe/PlatformSetupDxe.c | 145 +- > .../PlatformSetupDxe/Vfr.vfr | 17 +- > Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py | 348 +++++ > Platform/Intel/Vlv2TbltDevicePkg/Readme.md | 62 +- > .../Stitch/Gcc/NvStorageFtwSpare.bin | Bin 262144 -> 0 bytes > .../Stitch/Gcc/NvStorageFtwWorking.bin | Bin 8192 -> 0 bytes > .../Stitch/Gcc/NvStorageVariable.bin | Bin 253952 -> 0 bytes > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat | 322 ---- > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 235 --- > 49 files changed, 1227 insertions(+), 6137 deletions(-) > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BfmLib.exe > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.bat > delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FCE.exe > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleAll.bat > create mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleAll.py > delete mode 100755 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleAll.sh > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleMinnowMax.bat > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleMinnowMax.sh > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleMinnowMaxRelease.bat > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleMinnowMaxRelease.sh > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleSampleColor.bat > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCa >psuleSampleColor.sh > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/Lvfs.dd >f > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/LvfsGe >nCapsuleMinnowMax.bat > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/LvfsGe >nCapsuleMinnowMaxRelease.bat > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/LvfsGe >nCapsuleSampleColor.bat > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/templa >te.metainfo.xml > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescript >or/SystemFirmwareDescriptor.aslc > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescript >or/SystemFirmwareDescriptor.inf > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescript >or/SystemFirmwareDescriptorPei.c > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareUpdateC >onfig/SystemFirmwareUpdateConfig.ini > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareUpdateC >onfig/SystemFirmwareUpdateConfigGcc.ini > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.dsc > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsule.fdf > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.dsc > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > create mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc > create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageFtwSpare.bin > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageFtwWorking.bin > delete mode 100644 >Platform/Intel/Vlv2TbltDevicePkg/Stitch/Gcc/NvStorageVariable.bin > delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat > delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > >-- >2.21.0.windows.1 > > >