From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Sat, 20 Jul 2019 08:11:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jul 2019 08:11:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,287,1559545200"; d="scan'208";a="343971482" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 20 Jul 2019 08:11:18 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 20 Jul 2019 08:11:17 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 20 Jul 2019 08:11:17 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.134]) with mapi id 14.03.0439.000; Sat, 20 Jul 2019 23:11:15 +0800 From: "Liming Gao" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Sun, Zailiang" , "Qian, Yi" , Gary Lin Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Thread-Topic: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: Convert use of FCE tool to Structured PCD Thread-Index: AQHVPbys3EU6tiLj80yxGIZOeyhqxqbRSauA//+kdICAAI/d4IAAE9OAgAINXKA= Date: Sat, 20 Jul 2019 15:11:15 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4ACD60@SHSMSX104.ccr.corp.intel.com> References: <20190718230017.14852-1-michael.d.kinney@intel.com> <20190718230017.14852-3-michael.d.kinney@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC38E@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4AC568@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTRhNjRlOTctMDYxMS00YTE5LTg3ZDYtNTA2NjA1ZjRkMTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicVZoMllcL3grU1NwcTBVWEhcL200RURrSUh0RGRIam1WUnAwVnB2ZTQ2dWJhb1BabWxjYnlnVTFIUm9PRlI1c3FQIn0= dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike: Yes. I will update this wiki page. Thanks Liming > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, July 19, 2019 11:51 PM > To: Gao, Liming ; devel@edk2.groups.io; Kinney, Mic= hael D > Cc: Sun, Zailiang ; Qian, Yi ;= Gary Lin > Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] Vlv2TbltDevicePkg: C= onvert use of FCE tool to Structured PCD >=20 > Liming, >=20 > That wiki page does not explain that values are > inherited from STANDARD settings. It only shows > an example use of multiple default stores. >=20 > Mike >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Thursday, July 18, 2019 11:41 PM > > To: devel@edk2.groups.io; Kinney, Michael D > > > > Cc: Sun, Zailiang ; Qian, Yi > > ; Gary Lin > > Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] > > Vlv2TbltDevicePkg: Convert use of FCE tool to Structured > > PCD > > > > Mike: > > Yes. Wiki > > https://github.com/lgao4/edk2/wiki/StructurePcd-Enable- > > Steps shows the usage of the different default store. > > > > >-----Original Message----- > > >From: devel@edk2.groups.io > > [mailto:devel@edk2.groups.io] On Behalf Of > > >Michael D Kinney > > >Sent: Friday, July 19, 2019 2:05 PM > > >To: Gao, Liming ; > > devel@edk2.groups.io; Kinney, > > >Michael D > > >Cc: Sun, Zailiang ; Qian, Yi > > >; Gary Lin > > >Subject: Re: [edk2-devel] [edk2-platforms Patch 2/5] > > Vlv2TbltDevicePkg: > > >Convert use of FCE tool to Structured PCD > > > > > >Liming, > > > > > >Thanks for the feedback. I have made both changes in > > the V2 version of > > >the series. > > > > > >We should show some examples of inheriting defaults > > from STANDARD > > >defaults. > > > > > >Mike > > > > > >> -----Original Message----- > > >> From: Gao, Liming > > >> Sent: Thursday, July 18, 2019 8:41 PM > > >> To: devel@edk2.groups.io; Kinney, Michael D > > >> > > >> Cc: Sun, Zailiang ; Qian, Yi > > >> ; Gary Lin > > >> Subject: RE: [edk2-devel] [edk2-platforms Patch 2/5] > > >> Vlv2TbltDevicePkg: Convert use of FCE tool to > > Structured PCD > > >> > > >> Mike: > > >> I have two comments here. > > >> 1. VarStore is updated to EfiVarStore. So, > > HiiConfigAccess > > >> ExtractConfig() and RouteConfig() can be updated to > > directly return > > >> UNSUPPORTED, they are not used any more. > > >> 2. DSC doesn't need to include > > PlatformSetupDefaults.dsc twice. By > > >> default, MANUFACTURING setting will be inherited from > > STANDARD. Only > > >> different default setting is required to be > > specified. For your case, > > >> MANUFACTURING default is same to STANDARD. So, you > > only need to > > >> include the default setting for STANDARD only. > > >> > > >> [PcdsDynamicExHii.common.DEFAULT.STANDARD] > > >> !include > > Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc > > >> > > >> [PcdsDynamicExHii.common.DEFAULT.MANUFACTURING] # > > can be removed. > > >> !include > > Vlv2TbltDevicePkg/PlatformSetupDefaults.dsc > > >> # can be removed. > > >> > > >> Thanks > > >> Liming