public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools:Added arch output to build report
Date: Thu, 25 Jul 2019 02:15:12 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4B2557@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF9EC28@SHSMSX101.ccr.corp.intel.com>

I agree with this enhancement. Please update build spec for new ARCH field. 

Besides, this patch is from Mu project, please keep original author. 

Thanks
Liming
>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Thursday, July 25, 2019 8:45 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [PATCH] BaseTools:Added arch output to build report
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016
>
>Added arch output to build report so it's easy to tell
>which arch is being generated. Useful when multiple versions
>of a single module is being emitted for multiple archs.
>
>This patch is going to Added arch output
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index a3eb3b2383..b4189240e1 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -558,6 +558,7 @@ class ModuleReport(object):
>     def __init__(self, M, ReportType):
>         self.ModuleName = M.Module.BaseName
>         self.ModuleInfPath = M.MetaFile.File
>+        self.ModuleArch = M.Arch
>         self.FileGuid = M.Guid
>         self.Size = 0
>         self.BuildTimeStamp = None
>@@ -668,6 +669,7 @@ class ModuleReport(object):
>
>         FileWrite(File, "Module Summary")
>         FileWrite(File, "Module Name:          %s" % self.ModuleName)
>+        FileWrite(File, "Module Arch:          %s" % self.ModuleArch)
>         FileWrite(File, "Module INF Path:      %s" % self.ModuleInfPath)
>         FileWrite(File, "File GUID:            %s" % self.FileGuid)
>         if self.Size:
>--
>2.14.1.windows.1


      reply	other threads:[~2019-07-25  2:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25  0:45 [PATCH] BaseTools:Added arch output to build report Fan, ZhijuX
2019-07-25  2:15 ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4B2557@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox