public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] BaseTools:Added arch output to build report
@ 2019-07-25  0:45 Fan, ZhijuX
  2019-07-25  2:15 ` Liming Gao
  0 siblings, 1 reply; 2+ messages in thread
From: Fan, ZhijuX @ 2019-07-25  0:45 UTC (permalink / raw)
  To: devel@edk2.groups.io; +Cc: Gao, Liming, Feng, Bob C

[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016

Added arch output to build report so it's easy to tell
which arch is being generated. Useful when multiple versions
of a single module is being emitted for multiple archs.

This patch is going to Added arch output

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
 BaseTools/Source/Python/build/BuildReport.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index a3eb3b2383..b4189240e1 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -558,6 +558,7 @@ class ModuleReport(object):
     def __init__(self, M, ReportType):
         self.ModuleName = M.Module.BaseName
         self.ModuleInfPath = M.MetaFile.File
+        self.ModuleArch = M.Arch
         self.FileGuid = M.Guid
         self.Size = 0
         self.BuildTimeStamp = None
@@ -668,6 +669,7 @@ class ModuleReport(object):
 
         FileWrite(File, "Module Summary")
         FileWrite(File, "Module Name:          %s" % self.ModuleName)
+        FileWrite(File, "Module Arch:          %s" % self.ModuleArch)
         FileWrite(File, "Module INF Path:      %s" % self.ModuleInfPath)
         FileWrite(File, "File GUID:            %s" % self.FileGuid)
         if self.Size:
-- 
2.14.1.windows.1


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 3848 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] BaseTools:Added arch output to build report
  2019-07-25  0:45 [PATCH] BaseTools:Added arch output to build report Fan, ZhijuX
@ 2019-07-25  2:15 ` Liming Gao
  0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2019-07-25  2:15 UTC (permalink / raw)
  To: Fan, ZhijuX, devel@edk2.groups.io; +Cc: Feng, Bob C

I agree with this enhancement. Please update build spec for new ARCH field. 

Besides, this patch is from Mu project, please keep original author. 

Thanks
Liming
>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Thursday, July 25, 2019 8:45 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [PATCH] BaseTools:Added arch output to build report
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016
>
>Added arch output to build report so it's easy to tell
>which arch is being generated. Useful when multiple versions
>of a single module is being emitted for multiple archs.
>
>This patch is going to Added arch output
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index a3eb3b2383..b4189240e1 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -558,6 +558,7 @@ class ModuleReport(object):
>     def __init__(self, M, ReportType):
>         self.ModuleName = M.Module.BaseName
>         self.ModuleInfPath = M.MetaFile.File
>+        self.ModuleArch = M.Arch
>         self.FileGuid = M.Guid
>         self.Size = 0
>         self.BuildTimeStamp = None
>@@ -668,6 +669,7 @@ class ModuleReport(object):
>
>         FileWrite(File, "Module Summary")
>         FileWrite(File, "Module Name:          %s" % self.ModuleName)
>+        FileWrite(File, "Module Arch:          %s" % self.ModuleArch)
>         FileWrite(File, "Module INF Path:      %s" % self.ModuleInfPath)
>         FileWrite(File, "File GUID:            %s" % self.FileGuid)
>         if self.Size:
>--
>2.14.1.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-25  2:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-25  0:45 [PATCH] BaseTools:Added arch output to build report Fan, ZhijuX
2019-07-25  2:15 ` Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox