From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Wed, 24 Jul 2019 19:15:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 19:15:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,305,1559545200"; d="scan'208";a="253786288" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 24 Jul 2019 19:15:18 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jul 2019 19:15:14 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jul 2019 19:15:13 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.174]) with mapi id 14.03.0439.000; Thu, 25 Jul 2019 10:15:12 +0800 From: "Liming Gao" To: "Fan, ZhijuX" , "devel@edk2.groups.io" CC: "Feng, Bob C" Subject: Re: [PATCH] BaseTools:Added arch output to build report Thread-Topic: [PATCH] BaseTools:Added arch output to build report Thread-Index: AdVCgjufxRI0hRsXRXiEse0ZYSVnMAADE9cQ Date: Thu, 25 Jul 2019 02:15:12 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4B2557@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree with this enhancement. Please update build spec for new ARCH field.= =20 Besides, this patch is from Mu project, please keep original author.=20 Thanks Liming >-----Original Message----- >From: Fan, ZhijuX >Sent: Thursday, July 25, 2019 8:45 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [PATCH] BaseTools:Added arch output to build report > >BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2016 > >Added arch output to build report so it's easy to tell >which arch is being generated. Useful when multiple versions >of a single module is being emitted for multiple archs. > >This patch is going to Added arch output > >Cc: Bob Feng >Cc: Liming Gao >Signed-off-by: Zhiju.Fan >--- > BaseTools/Source/Python/build/BuildReport.py | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/BaseTools/Source/Python/build/BuildReport.py >b/BaseTools/Source/Python/build/BuildReport.py >index a3eb3b2383..b4189240e1 100644 >--- a/BaseTools/Source/Python/build/BuildReport.py >+++ b/BaseTools/Source/Python/build/BuildReport.py >@@ -558,6 +558,7 @@ class ModuleReport(object): > def __init__(self, M, ReportType): > self.ModuleName =3D M.Module.BaseName > self.ModuleInfPath =3D M.MetaFile.File >+ self.ModuleArch =3D M.Arch > self.FileGuid =3D M.Guid > self.Size =3D 0 > self.BuildTimeStamp =3D None >@@ -668,6 +669,7 @@ class ModuleReport(object): > > FileWrite(File, "Module Summary") > FileWrite(File, "Module Name: %s" % self.ModuleName) >+ FileWrite(File, "Module Arch: %s" % self.ModuleArch) > FileWrite(File, "Module INF Path: %s" % self.ModuleInfPath) > FileWrite(File, "File GUID: %s" % self.FileGuid) > if self.Size: >-- >2.14.1.windows.1