public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Javeed, Ashraf" <ashraf.javeed@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol
Date: Thu, 25 Jul 2019 15:47:28 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C01E7@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <95C5C2B113DE604FB208120C742E9824578BEA95@BGSMSX101.gar.corp.intel.com>

V2 is still full patch. It is not the change delta since the first patch. If this patch pass review, it will push. The final push patch should be same to the reviewed patch. 

Thanks
Liming
> -----Original Message-----
> From: Javeed, Ashraf
> Sent: Thursday, July 25, 2019 11:42 PM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat
> protocol
> 
> Liming,
> I meant to create only second patch, I just appended the commit message with the actual changes details from the previous patch.
> 
> > New interface added to PCI Platform Protocol / PCI Override Protocol
> > to retrieve device-specific platform policy for the following PCI
> > standard features, like Maximum Payload Size (MPS), Maximum Read
> > Request Size (MRRS),Extended Tags, Relax Order, No-Snoop, Active State
> > Power Management (ASPM),Latency Time Reporting (LTR), AtomicOp,
> > Reference Clock Configuration, Extended SYNCH, PTM support, and Completion Timeout (CTO).
> > New source files added with enhanced definitions are in:
> > MdePkg/Include/Protocol/PciPlatform2.h,
> > MdePkg/Include/Protocol/PciOverride2.h
> 
> Thanks
> Ashraf
> 
> > -----Original Message-----
> > From: Gao, Liming
> > Sent: Thursday, July 25, 2019 9:01 PM
> > To: devel@edk2.groups.io; Javeed, Ashraf <ashraf.javeed@intel.com>
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> > <ray.ni@intel.com>
> > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2]
> > MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol
> >
> > Ashraf:
> >   V2 is the updated full patch, not patch 2. I think you mean to create single
> > patch to include all changes instead of create two patches. Right?
> >
> > Thanks
> > Liming
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > > Javeed, Ashraf
> > > Sent: Thursday, July 25, 2019 10:45 PM
> > > To: devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> > > Subject: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2]
> > > MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol
> > >
> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1954
> > >
> > > In V2: Correction made to header sections of source files
> > >
> > > New interface added to PCI Platform Protocol / PCI Override Protocol
> > > to retrieve device-specific platform policy for the following PCI
> > > standard features, like Maximum Payload Size (MPS), Maximum Read
> > > Request Size (MRRS),Extended Tags, Relax Order, No-Snoop, Active State
> > > Power Management (ASPM),Latency Time Reporting (LTR), AtomicOp,
> > > Reference Clock Configuration, Extended SYNCH, PTM support, and
> > Completion Timeout (CTO).
> > > New source files added with enhanced definitions are in:
> > > MdePkg/Include/Protocol/PciPlatform2.h,
> > > MdePkg/Include/Protocol/PciOverride2.h
> > >
> > > Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > ---
> > >  MdePkg/Include/Protocol/PciOverride2.h | 3 ---
> > > MdePkg/Include/Protocol/PciPlatform2.h | 5 +----
> > >  2 files changed, 1 insertion(+), 7 deletions(-)
> > >
> > > diff --git a/MdePkg/Include/Protocol/PciOverride2.h
> > > b/MdePkg/Include/Protocol/PciOverride2.h
> > > index cf452d9f8f..a7f541b4c3 100644
> > > --- a/MdePkg/Include/Protocol/PciOverride2.h
> > > +++ b/MdePkg/Include/Protocol/PciOverride2.h
> > > @@ -13,9 +13,6 @@
> > >    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> > BASIS,
> > >    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> > EXPRESS OR IMPLIED.
> > >
> > > -  @par Revision Reference:
> > > -  This Protocol is defined in UEFI Platform Initialization
> > > Specification 1.2
> > > -  Volume 5: Standards
> > >
> > >  **/
> > >
> > > diff --git a/MdePkg/Include/Protocol/PciPlatform2.h
> > > b/MdePkg/Include/Protocol/PciPlatform2.h
> > > index 3ff41b7754..717938e68d 100644
> > > --- a/MdePkg/Include/Protocol/PciPlatform2.h
> > > +++ b/MdePkg/Include/Protocol/PciPlatform2.h
> > > @@ -4,7 +4,7 @@
> > >    driver to describe the unique features of a platform.
> > >    This protocol is optional.
> > >
> > > -Copyright (c) 2007 - 2019, Intel Corporation. All rights
> > > reserved.<BR>
> > > +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > >  This program and the accompanying materials are licensed and made
> > > available under  the terms and conditions of the BSD License that accompanies
> > this distribution.
> > >  The full text of the license may be found at @@ -13,9 +13,6 @@
> > > http://opensource.org/licenses/bsd-license.php.
> > >  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> > BASIS,
> > > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> > EXPRESS OR IMPLIED.
> > >
> > > -  @par Revision Reference:
> > > -  This Protocol is defined in UEFI Platform Initialization
> > > Specification 1.2
> > > -  Volume 5: Standards
> > >
> > >  **/
> > >
> > > --
> > > 2.21.0.windows.1
> > >
> > >
> > > 


  reply	other threads:[~2019-07-25 15:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25 14:45 [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol Javeed, Ashraf
2019-07-25 15:30 ` [edk2-devel] " Liming Gao
2019-07-25 15:41   ` Javeed, Ashraf
2019-07-25 15:47     ` Liming Gao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-07-29  6:51 Javeed, Ashraf
2019-07-29  7:52 ` Liming Gao
2019-07-29  8:05   ` [edk2-devel] " Yao, Jiewen
2019-07-29  8:12     ` Javeed, Ashraf
2019-07-29  8:56       ` Yao, Jiewen
2019-07-29 11:17         ` Javeed, Ashraf
2019-07-29 12:18           ` Yao, Jiewen
2019-07-29 14:27             ` Javeed, Ashraf
     [not found]           ` <15B5DFFD7DF9B8EB.10519@groups.io>
2019-07-29 12:25             ` Yao, Jiewen
2019-07-29 14:39               ` Javeed, Ashraf
2019-07-30  3:26                 ` Liming Gao
     [not found] <15B5CE29E665BA8A.10483@groups.io>
2019-07-29  7:08 ` Javeed, Ashraf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4C01E7@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox