From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Thu, 25 Jul 2019 08:47:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 08:47:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,307,1559545200"; d="scan'208";a="193847291" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 25 Jul 2019 08:47:31 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jul 2019 08:47:31 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jul 2019 08:47:30 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Thu, 25 Jul 2019 23:47:29 +0800 From: "Liming Gao" To: "Javeed, Ashraf" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol Thread-Topic: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol Thread-Index: AQHVQvechCnr/dLaNk2eszVE3sw+yabbdTwg//99s4CAAIZ1gA== Date: Thu, 25 Jul 2019 15:47:28 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C01E7@SHSMSX104.ccr.corp.intel.com> References: <20190725144518.8536-1-ashraf.javeed@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4BF18D@SHSMSX104.ccr.corp.intel.com> <95C5C2B113DE604FB208120C742E9824578BEA95@BGSMSX101.gar.corp.intel.com> In-Reply-To: <95C5C2B113DE604FB208120C742E9824578BEA95@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDYyNmZjMzQtODc3MS00NTc5LWEzZGYtOGNlZGYxYWFmYzY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMmRKOUx3UmhuejNIUmc3bXptV0g1aklrUXczejQ3NWVqUFB3MWgxSXJKVVNjd3NxMjZHMmNWQndIaDdoT2FtYiJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable V2 is still full patch. It is not the change delta since the first patch. I= f this patch pass review, it will push. The final push patch should be same= to the reviewed patch.=20 Thanks Liming > -----Original Message----- > From: Javeed, Ashraf > Sent: Thursday, July 25, 2019 11:42 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Ni, Ray > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] Mde= Pkg/Protocols: New interface, EFI encodings to PCI Plat > protocol >=20 > Liming, > I meant to create only second patch, I just appended the commit message = with the actual changes details from the previous patch. >=20 > > New interface added to PCI Platform Protocol / PCI Override Protocol > > to retrieve device-specific platform policy for the following PCI > > standard features, like Maximum Payload Size (MPS), Maximum Read > > Request Size (MRRS),Extended Tags, Relax Order, No-Snoop, Active State > > Power Management (ASPM),Latency Time Reporting (LTR), AtomicOp, > > Reference Clock Configuration, Extended SYNCH, PTM support, and Comple= tion Timeout (CTO). > > New source files added with enhanced definitions are in: > > MdePkg/Include/Protocol/PciPlatform2.h, > > MdePkg/Include/Protocol/PciOverride2.h >=20 > Thanks > Ashraf >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Thursday, July 25, 2019 9:01 PM > > To: devel@edk2.groups.io; Javeed, Ashraf > > Cc: Kinney, Michael D ; Ni, Ray > > > > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] > > MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol > > > > Ashraf: > > V2 is the updated full patch, not patch 2. I think you mean to creat= e single > > patch to include all changes instead of create two patches. Right? > > > > Thanks > > Liming > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf O= f > > > Javeed, Ashraf > > > Sent: Thursday, July 25, 2019 10:45 PM > > > To: devel@edk2.groups.io > > > Cc: Kinney, Michael D ; Gao, Liming > > > ; Ni, Ray > > > Subject: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] > > > MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1954 > > > > > > In V2: Correction made to header sections of source files > > > > > > New interface added to PCI Platform Protocol / PCI Override Protocol > > > to retrieve device-specific platform policy for the following PCI > > > standard features, like Maximum Payload Size (MPS), Maximum Read > > > Request Size (MRRS),Extended Tags, Relax Order, No-Snoop, Active Sta= te > > > Power Management (ASPM),Latency Time Reporting (LTR), AtomicOp, > > > Reference Clock Configuration, Extended SYNCH, PTM support, and > > Completion Timeout (CTO). > > > New source files added with enhanced definitions are in: > > > MdePkg/Include/Protocol/PciPlatform2.h, > > > MdePkg/Include/Protocol/PciOverride2.h > > > > > > Signed-off-by: Ashraf Javeed > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Ray Ni > > > --- > > > MdePkg/Include/Protocol/PciOverride2.h | 3 --- > > > MdePkg/Include/Protocol/PciPlatform2.h | 5 +---- > > > 2 files changed, 1 insertion(+), 7 deletions(-) > > > > > > diff --git a/MdePkg/Include/Protocol/PciOverride2.h > > > b/MdePkg/Include/Protocol/PciOverride2.h > > > index cf452d9f8f..a7f541b4c3 100644 > > > --- a/MdePkg/Include/Protocol/PciOverride2.h > > > +++ b/MdePkg/Include/Protocol/PciOverride2.h > > > @@ -13,9 +13,6 @@ > > > THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > > EXPRESS OR IMPLIED. > > > > > > - @par Revision Reference: > > > - This Protocol is defined in UEFI Platform Initialization > > > Specification 1.2 > > > - Volume 5: Standards > > > > > > **/ > > > > > > diff --git a/MdePkg/Include/Protocol/PciPlatform2.h > > > b/MdePkg/Include/Protocol/PciPlatform2.h > > > index 3ff41b7754..717938e68d 100644 > > > --- a/MdePkg/Include/Protocol/PciPlatform2.h > > > +++ b/MdePkg/Include/Protocol/PciPlatform2.h > > > @@ -4,7 +4,7 @@ > > > driver to describe the unique features of a platform. > > > This protocol is optional. > > > > > > -Copyright (c) 2007 - 2019, Intel Corporation. All rights > > > reserved.
> > > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> > > This program and the accompanying materials are licensed and made > > > available under the terms and conditions of the BSD License that ac= companies > > this distribution. > > > The full text of the license may be found at @@ -13,9 +13,6 @@ > > > http://opensource.org/licenses/bsd-license.php. > > > THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > > EXPRESS OR IMPLIED. > > > > > > - @par Revision Reference: > > > - This Protocol is defined in UEFI Platform Initialization > > > Specification 1.2 > > > - Volume 5: Standards > > > > > > **/ > > > > > > -- > > > 2.21.0.windows.1 > > > > > > > > >=20