From: "Liming Gao" <liming.gao@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Fan, ZhijuX" <zhijux.fan@intel.com>
Cc: Sean Brogan <spbrogan@live.com>, "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH V2] BaseTools: replace the chinese quotation mark with unicode "
Date: Fri, 26 Jul 2019 06:44:32 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C277F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <edbff333-49c3-6c1c-5c17-017f53d6bd79@redhat.com>
>-----Original Message-----
>From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
>Sent: Thursday, July 25, 2019 7:12 PM
>To: devel@edk2.groups.io; Fan, ZhijuX <zhijux.fan@intel.com>
>Cc: Sean Brogan <spbrogan@live.com>; Feng, Bob C <bob.c.feng@intel.com>;
>Gao, Liming <liming.gao@intel.com>
>Subject: Re: [edk2-devel] [PATCH V2] BaseTools: replace the chinese
>quotation mark with unicode "
>
>On 7/25/19 5:00 AM, Fan, ZhijuX wrote:
>> From: Sean Brogan <spbrogan@live.com>
>>
>> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013
>>
>> chinese quotation mark are used in the file
>> This patch is going to fix that issue.
>>
>> Cc: Bob Feng <bob.c.feng@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>> ---
>> BaseTools/Source/Python/Pkcs7Sign/Readme.md | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/BaseTools/Source/Python/Pkcs7Sign/Readme.md
>b/BaseTools/Source/Python/Pkcs7Sign/Readme.md
>> index 5315b7fca4..a7b9caf52c 100644
>> --- a/BaseTools/Source/Python/Pkcs7Sign/Readme.md
>> +++ b/BaseTools/Source/Python/Pkcs7Sign/Readme.md
>> @@ -10,7 +10,7 @@ NOTE: Below steps are required for Windows. Linux
>may already have the OPENSSL e
>> set OPENSSL_HOME=c:\home\openssl\openssl-[version]
>> set OPENSSL_CONF=%OPENSSL_HOME%\apps\openssl.cnf
>>
>> -When a user uses OpenSSL (req or ca command) to generate the
>certificates, OpenSSL will use the openssl.cnf file as the configuration data
>(can use “-config path/to/openssl.cnf” to describe the specific config file).
>> +When a user uses OpenSSL (req or ca command) to generate the
>certificates, OpenSSL will use the openssl.cnf file as the configuration data
>(can use "-config path/to/openssl.cnf" to describe the specific config file).
>>
>> The user need check the openssl.cnf file, to find your CA path setting, e.g.
>check if the path exists in [ CA_default ] section.
>>
>
>I wonder, we could add a BaseTool script as pre-commit hook to check
>this kind of easy typos...
>
>Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Thanks
Liming
prev parent reply other threads:[~2019-07-26 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 3:00 [PATCH V2] BaseTools: replace the chinese quotation mark with unicode " Fan, ZhijuX
2019-07-25 11:12 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-26 6:44 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4C277F@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox