From: "Liming Gao" <liming.gao@intel.com>
To: "Xu, Wei6" <wei6.xu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel][Patch 0/3] Add destructor to CloseEvent
Date: Fri, 26 Jul 2019 08:28:09 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C28B0@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190726031055.10020-1-wei6.xu@intel.com>
Thanks for your fix. The patch set is good.
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Xu, Wei6
>Sent: Friday, July 26, 2019 11:11 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [edk2-devel][Patch 0/3] Add destructor to CloseEvent
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012
>
>This patch set adds missing destructor for following libraries:
>MdePkg\Library\UefiDebugLibStdErr
>MdePkg\Library\UefiDebugLibConOut
>MdePkg\Library\UefiDebugLibDebugPortProtocol
>
>When driver is unloaded, the ExitBootSerivesEvent must be closed at
>the same time. Otherwise exception will occur when ExitBootServices.
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>
>Wei6 Xu (3):
> MdePkg/UefiDebugLibConOut: Add destructor to CloseEvent
> MdePkg/UefiDebugLibDebugPortProtocol: Add destructor to CloseEvent
> MdePkg/UefiDebugLibStdErr: Add destructor to CloseEvent
>
> .../UefiDebugLibConOut/DebugLibConstructor.c | 23
>++++++++++++++++++++++
> .../UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 +
> .../DebugLibConstructor.c | 23 ++++++++++++++++++++++
> .../UefiDebugLibDebugPortProtocol.inf | 1 +
> .../UefiDebugLibStdErr/DebugLibConstructor.c | 23
>++++++++++++++++++++++
> .../UefiDebugLibStdErr/UefiDebugLibStdErr.inf | 1 +
> 6 files changed, 72 insertions(+)
>
>--
>2.16.2.windows.1
prev parent reply other threads:[~2019-07-26 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 3:10 [edk2-devel][Patch 0/3] Add destructor to CloseEvent Xu, Wei6
2019-07-26 3:10 ` [edk2-devel][Patch 1/3] MdePkg/UefiDebugLibConOut: " Xu, Wei6
2019-07-29 14:38 ` Philippe Mathieu-Daudé
2019-07-29 16:09 ` Laszlo Ersek
2019-07-29 17:48 ` Philippe Mathieu-Daudé
2019-07-30 1:17 ` Liming Gao
2019-07-26 3:10 ` [edk2-devel][Patch 2/3] MdePkg/UefiDebugLibDebugPortProtocol: " Xu, Wei6
2019-07-26 3:10 ` [edk2-devel][Patch 3/3] MdePkg/UefiDebugLibStdErr: " Xu, Wei6
2019-07-26 8:28 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4C28B0@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox