From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Fri, 26 Jul 2019 01:28:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 01:28:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,310,1559545200"; d="scan'208";a="161234021" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 26 Jul 2019 01:28:12 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 26 Jul 2019 01:28:12 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 26 Jul 2019 01:28:11 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 26 Jul 2019 01:28:11 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.204]) with mapi id 14.03.0439.000; Fri, 26 Jul 2019 16:28:10 +0800 From: "Liming Gao" To: "Xu, Wei6" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [edk2-devel][Patch 0/3] Add destructor to CloseEvent Thread-Topic: [edk2-devel][Patch 0/3] Add destructor to CloseEvent Thread-Index: AQHVQ1/D8wQpn0tbdES5AxzuKrgGhqbckUAA Date: Fri, 26 Jul 2019 08:28:09 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C28B0@SHSMSX104.ccr.corp.intel.com> References: <20190726031055.10020-1-wei6.xu@intel.com> In-Reply-To: <20190726031055.10020-1-wei6.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for your fix. The patch set is good.=20 Reviewed-by: Liming Gao >-----Original Message----- >From: Xu, Wei6 >Sent: Friday, July 26, 2019 11:11 AM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [edk2-devel][Patch 0/3] Add destructor to CloseEvent > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2012 > >This patch set adds missing destructor for following libraries: >MdePkg\Library\UefiDebugLibStdErr >MdePkg\Library\UefiDebugLibConOut >MdePkg\Library\UefiDebugLibDebugPortProtocol > >When driver is unloaded, the ExitBootSerivesEvent must be closed at >the same time. Otherwise exception will occur when ExitBootServices. > >Cc: Michael D Kinney >Cc: Liming Gao > >Wei6 Xu (3): > MdePkg/UefiDebugLibConOut: Add destructor to CloseEvent > MdePkg/UefiDebugLibDebugPortProtocol: Add destructor to CloseEvent > MdePkg/UefiDebugLibStdErr: Add destructor to CloseEvent > > .../UefiDebugLibConOut/DebugLibConstructor.c | 23 >++++++++++++++++++++++ > .../UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 + > .../DebugLibConstructor.c | 23 +++++++++++++++++= +++++ > .../UefiDebugLibDebugPortProtocol.inf | 1 + > .../UefiDebugLibStdErr/DebugLibConstructor.c | 23 >++++++++++++++++++++++ > .../UefiDebugLibStdErr/UefiDebugLibStdErr.inf | 1 + > 6 files changed, 72 insertions(+) > >-- >2.16.2.windows.1