From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Mon, 29 Jul 2019 00:49:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 00:49:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,321,1559545200"; d="scan'208";a="199508385" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 29 Jul 2019 00:49:53 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 00:49:53 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 00:49:52 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Mon, 29 Jul 2019 15:49:51 +0800 From: "Liming Gao" To: "Chen, Marc W" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Ni, Ray" Subject: Re: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file Thread-Topic: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file Thread-Index: AQHVQ5q/GL7KY5kyBUa6rCuJj9sJ1KbhPOkA Date: Mon, 29 Jul 2019 07:49:50 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C44B8@SHSMSX104.ccr.corp.intel.com> References: <20190726101246.20468-1-marc.w.chen@intel.com> In-Reply-To: <20190726101246.20468-1-marc.w.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Marc: In PI spec 1.6, I see the guid macro is defined as EFI_SMM_SMRAM_MEMORY_G= UID.=20 Why you define it as EFI_SMRAM_MEMORY_RESERVE_GUID? Thanks Liming >-----Original Message----- >From: Chen, Marc W >Sent: Friday, July 26, 2019 6:13 PM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming >; Ni, Ray >Subject: [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file > >This is a special GUID extension Hob to describe SMRAM memory regions > >Cc: Michael D Kinney >Cc: Liming Gao >Cc: Ray Ni >Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2020 >Signed-off-by: Marc W Chen >--- > MdePkg/Include/Guid/SmramMemoryReserve.h | 45 >++++++++++++++++++++++++++++++++ > MdePkg/MdePkg.dec | 3 +++ > 2 files changed, 48 insertions(+) > create mode 100644 MdePkg/Include/Guid/SmramMemoryReserve.h > >diff --git a/MdePkg/Include/Guid/SmramMemoryReserve.h >b/MdePkg/Include/Guid/SmramMemoryReserve.h >new file mode 100644 >index 0000000000..9bb4925711 >--- /dev/null >+++ b/MdePkg/Include/Guid/SmramMemoryReserve.h >@@ -0,0 +1,45 @@ >+/** @file >+ This is a special GUID extension Hob to describe SMRAM memory regions. >+ >+ This file defines: >+ * the GUID used to identify the GUID HOB for reserving SMRAM regions. >+ * the data structure of SMRAM descriptor to describe SMRAM candidate >regions >+ * values of state of SMRAM candidate regions >+ * the GUID specific data structure of HOB for reserving SMRAM regions. >+ >+ Copyright (c) 2019, Intel Corporation. All rights reserved.
>+ SPDX-License-Identifier: BSD-2-Clause-Patent >+ >+ @par Revision Reference: >+ GUIDs defined in PI SPEC version 1.5. >+ >+**/ >+ >+#ifndef _EFI_SMRAM_MEMORY_RESERVE_H_ >+#define _EFI_SMRAM_MEMORY_RESERVE_H_ >+ >+#define EFI_SMRAM_MEMORY_RESERVE_GUID \ >+ { \ >+ 0x6dadf1d1, 0xd4cc, 0x4910, {0xbb, 0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff= , 0x3d } >\ >+ } >+ >+/** >+* The GUID extension hob is to describe SMRAM memory regions supported >by the platform. >+**/ >+typedef struct { >+ /// >+ /// Designates the number of possible regions in the system >+ /// that can be usable for SMRAM. >+ /// >+ UINT32 NumberOfSmmReservedRegions; >+ /// >+ /// Used throughout this protocol to describe the candidate >+ /// regions for SMRAM that are supported by this platform. >+ /// >+ EFI_SMRAM_DESCRIPTOR Descriptor[1]; >+} EFI_SMRAM_HOB_DESCRIPTOR_BLOCK; >+ >+extern EFI_GUID gEfiSmramMemoryReserveGuid; >+ >+#endif >+ >diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >index b382efd578..5cc12886fa 100644 >--- a/MdePkg/MdePkg.dec >+++ b/MdePkg/MdePkg.dec >@@ -749,6 +749,9 @@ > ## Include/Guid/GraphicsInfoHob.h > gEfiGraphicsDeviceInfoHobGuid =3D { 0xe5cb2ac9, 0xd35d, 0x4430, { 0= x93, >0x6e, 0x1d, 0xe3, 0x32, 0x47, 0x8d, 0xe7 }} > >+ ## Include/Guid/SmramMemoryReserve.h >+ gEfiSmramMemoryReserveGuid =3D { 0x6dadf1d1, 0xd4cc, 0x4910, { 0xbb= , >0x6e, 0x82, 0xb1, 0xfd, 0x80, 0xff, 0x3d }} >+ > # > # GUID defined in PI1.6 > # >-- >2.16.2.windows.1