From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Mon, 29 Jul 2019 20:29:29 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 20:29:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,325,1559545200"; d="scan'208";a="176645365" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 29 Jul 2019 20:29:28 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 20:29:28 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 20:29:27 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Tue, 30 Jul 2019 11:29:26 +0800 From: "Liming Gao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Dong, Eric" , Laszlo Ersek Subject: Re: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Topic: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Index: AQHVQgbAogcK2schRUq8UZx+6VE+n6biidNw Date: Tue, 30 Jul 2019 03:29:25 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4F55@SHSMSX104.ccr.corp.intel.com> References: <20190724100029.252404-1-ray.ni@intel.com> <20190724100029.252404-6-ray.ni@intel.com> In-Reply-To: <20190724100029.252404-6-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTU2NTEwY2EtMGZmMy00ZTFiLWE0OGEtODc3ZjgyZDMzYzkxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibHJObkJidTJPemRpSVk4TEt0WUNOT0xkQlM5Um9SKzhvRFY5SHZyYW9ucGlITHZtTlNCXC81c2dpNFJ6c003T0cifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The change is good to me. Reviewed-by: Liming Gao > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, July 24, 2019 6:00 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming ; Dong, Eric ; Laszlo > Ersek > Subject: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to M= dePkg >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2008 >=20 > MdeModulePkg/DxeIpl needs to get CPUID output for CPU > 5-level paging capability detection. >=20 > In order to use the macros/structures defined in > UefiCpuPkg/Include/Register/Cpuid.h, the patch moves > Cpuid.h to MdePkg/Include/Register/ directory. >=20 > Because almost every module depends on MdePkg.dec in its > INF file, the move almost has no impact. >=20 > Signed-off-by: Ray Ni > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Eric Dong > Cc: Laszlo Ersek > --- > {UefiCpuPkg =3D> MdePkg}/Include/Register/Cpuid.h | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename {UefiCpuPkg =3D> MdePkg}/Include/Register/Cpuid.h (100%) >=20 > diff --git a/UefiCpuPkg/Include/Register/Cpuid.h b/MdePkg/Include/Registe= r/Cpuid.h > similarity index 100% > rename from UefiCpuPkg/Include/Register/Cpuid.h > rename to MdePkg/Include/Register/Cpuid.h > -- > 2.21.0.windows.1