From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Mon, 29 Jul 2019 20:46:27 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 20:46:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,325,1559545200"; d="scan'208";a="174110651" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 29 Jul 2019 20:46:26 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 20:46:26 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 20:46:26 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.80]) with mapi id 14.03.0439.000; Tue, 30 Jul 2019 11:46:24 +0800 From: "Liming Gao" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD Thread-Topic: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD Thread-Index: AQHVRf3jfJKKO6sbYkOmBgv0fdlMuqbihkvw Date: Tue, 30 Jul 2019 03:46:23 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4F93@SHSMSX104.ccr.corp.intel.com> References: <20190729110715.2312-1-chasel.chiu@intel.com> In-Reply-To: <20190729110715.2312-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGJjNmEyMTUtZjIzMy00YTQ3LTliNmItNjc1NWUxYzc2NzgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK3RWWXY4NGM4ODROXC80N3N2OVNRaVFpbGxrK0RCOWlZeEFJSkNtNzVpZjlkdlwvS2llU3habzVWdmI1U242TW8xIn0= dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Chasel: This is a good enhancement. With this change, can RebaseAndPatchFspBinBas= eAddress.py and PatchFspBinFvsBaseAddress.py be removed? Thanks Liming > -----Original Message----- > From: Chiu, Chasel > Sent: Monday, July 29, 2019 7:07 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Sinha, Ankit ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1863 >=20 > PcdFsp*BaseAddress now will be updated in FDF basing > on flash map. > DSC will only define types of those PCDs and always > having 0 as default. > New script added to only rebase FSP binary without > patching DSC file. >=20 > Test: interanl platform booted with this patch. >=20 > Cc: Michael Kubacki > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Chasel Chiu >=20 > Chasel Chiu (4): > MinPlatformPkg: Auto configure Fsp*BaseAddress PCD > Platform/Intel: Auto configure Fsp*BaseAddress PCD > KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD >=20 > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | = 3 +++ > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc | 1= 2 +++++++++--- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | = 3 +++ > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 1= 2 +++++++++--- > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 9= 6 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++ > Platform/Intel/build_bios.py | = 7 ++----- > 6 files changed, 122 insertions(+), 11 deletions(-) > create mode 100644 Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinB= aseAddress.py >=20 > -- > 2.13.3.windows.1