From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Mon, 29 Jul 2019 20:49:15 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 20:49:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,325,1559545200"; d="scan'208";a="195662596" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 29 Jul 2019 20:49:11 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 20:49:11 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 20:49:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Tue, 30 Jul 2019 11:49:08 +0800 From: "Liming Gao" To: "Kinney, Michael D" , "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek Subject: Re: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Topic: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Index: AQHVQgbAogcK2schRUq8UZx+6VE+n6biidNw//99iwCAAId7UA== Date: Tue, 30 Jul 2019 03:49:08 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4FAC@SHSMSX104.ccr.corp.intel.com> References: <20190724100029.252404-1-ray.ni@intel.com> <20190724100029.252404-6-ray.ni@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4F55@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2E3MDNmZDgtOGJkYS00ZDYyLTgyM2QtZjBmMjVjMTQwM2M4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVnFQblRoYTVnV1pjUGs4eXBxZkdXaXUwd0RXYTR0K25wUzVkVm9vSm5rcnhVMEF4QytRVHZUeUF1R2FWVnNXSiJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike: OK. If so, the consumer code also need to obviously include vendor header= file, such as #include . Right? Thanks Liming > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, July 30, 2019 11:42 AM > To: Gao, Liming ; Ni, Ray ; devel= @edk2.groups.io; Kinney, Michael D > > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg = to MdePkg >=20 > Liming, >=20 > There is an unresolved discussion on the location of this > file in the MdePkg. I prefer a vendor name in the path. >=20 > MdePkg/Include/Register/Intel/Cpuid.h >=20 > Also, after this file is moved to MdePkg, we can enter > new BZs to update all the modules that call AsmCpuid and > AsmCpuidEx to use the defines and structures from Cpuid.h. >=20 > Mike >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Monday, July 29, 2019 8:29 PM > > To: Ni, Ray ; devel@edk2.groups.io > > Cc: Kinney, Michael D ; > > Dong, Eric ; Laszlo Ersek > > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > > Cpuid.h from UefiCpuPkg to MdePkg > > > > The change is good to me. Reviewed-by: Liming Gao > > > > > > > -----Original Message----- > > > From: Ni, Ray > > > Sent: Wednesday, July 24, 2019 6:00 PM > > > To: devel@edk2.groups.io > > > Cc: Kinney, Michael D ; > > Gao, Liming > > > ; Dong, Eric > > ; Laszlo Ersek > > > > > > Subject: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h > > from UefiCpuPkg > > > to MdePkg > > > > > > REF: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2008 > > > > > > MdeModulePkg/DxeIpl needs to get CPUID output for CPU > > 5-level paging > > > capability detection. > > > > > > In order to use the macros/structures defined in > > > UefiCpuPkg/Include/Register/Cpuid.h, the patch moves > > Cpuid.h to > > > MdePkg/Include/Register/ directory. > > > > > > Because almost every module depends on MdePkg.dec in > > its INF file, the > > > move almost has no impact. > > > > > > Signed-off-by: Ray Ni > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Eric Dong > > > Cc: Laszlo Ersek > > > --- > > > {UefiCpuPkg =3D> MdePkg}/Include/Register/Cpuid.h | 0 > > > 1 file changed, 0 insertions(+), 0 deletions(-) > > rename {UefiCpuPkg > > > =3D> MdePkg}/Include/Register/Cpuid.h (100%) > > > > > > diff --git a/UefiCpuPkg/Include/Register/Cpuid.h > > > b/MdePkg/Include/Register/Cpuid.h similarity index > > 100% rename from > > > UefiCpuPkg/Include/Register/Cpuid.h > > > rename to MdePkg/Include/Register/Cpuid.h > > > -- > > > 2.21.0.windows.1