From: "Liming Gao" <liming.gao@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
Date: Thu, 1 Aug 2019 16:13:23 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C7835@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515CBCD08B27@FMSMSX103.amr.corp.intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Carsey, Jaben
> Sent: Thursday, August 1, 2019 10:45 PM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
> Thanks
> -Jaben
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Bob Feng
> > Sent: Thursday, August 01, 2019 6:24 AM
> > To: devel@edk2.groups.io
> > Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
> > <bob.c.feng@intel.com>
> > Subject: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> >
> > This is a regression issue introduced
> > by commit 307e1650be267b67db7be1089e0979ace460d83
> >
> > This patch is to fix this issue.
> >
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> > ---
> > BaseTools/Source/Python/Trim/Trim.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Source/Python/Trim/Trim.py
> > b/BaseTools/Source/Python/Trim/Trim.py
> > index 8767b67f7e..24c3fafa76 100644
> > --- a/BaseTools/Source/Python/Trim/Trim.py
> > +++ b/BaseTools/Source/Python/Trim/Trim.py
> > @@ -73,11 +73,11 @@ def TrimPreprocessedFile(Source, Target,
> > ConvertHex, TrimLong):
> > try:
> > with open(Source, "r") as File:
> > Lines = File.readlines()
> > except IOError:
> > EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> > - expect:
> > + except:
> > EdkLogger.error("Trim", AUTOGEN_ERROR, "TrimPreprocessedFile: Error
> > while processing file", File=Source)
> >
> > PreprocessedFile = ""
> > InjectedFile = ""
> > LineIndexOfOriginalFile = None
> > --
> > 2.18.0.windows.1
> >
> >
> >
next prev parent reply other threads:[~2019-08-01 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 13:23 [Patch] BaseTools: Fixed a typo in Trim.py Bob Feng
2019-08-01 14:44 ` [edk2-devel] " Carsey, Jaben
2019-08-01 16:13 ` Liming Gao [this message]
[not found] ` <15B6D88ADF05C073.3315@groups.io>
2019-08-01 16:26 ` Liming Gao
2019-08-01 16:10 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4C7835@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox