From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by groups.io with SMTP; Thu, 01 Aug 2019 09:13:31 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 09:13:27 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,334,1559545200"; 
   d="scan'208";a="324289699"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
  by orsmga004.jf.intel.com with ESMTP; 01 Aug 2019 09:13:27 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 1 Aug 2019 09:13:27 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 1 Aug 2019 09:13:27 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.80]) with mapi id 14.03.0439.000;
 Fri, 2 Aug 2019 00:13:24 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>, "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
Thread-Topic: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
Thread-Index: AQHVSGxd0wkipS4LDU+EyGeYUEM84abl2FqAgACe3IA=
Date: Thu, 1 Aug 2019 16:13:23 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C7835@SHSMSX104.ccr.corp.intel.com>
References: <20190801132343.10628-1-bob.c.feng@intel.com>
 <CB6E33457884FA40993F35157061515CBCD08B27@FMSMSX103.amr.corp.intel.com>
In-Reply-To: <CB6E33457884FA40993F35157061515CBCD08B27@FMSMSX103.amr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTc0N2I0MzMtY2E5YS00MzVlLWE0MjYtMmU2MWJjODQ2MDE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibEw0M2ZSNXFFS09oclVcL0MrcFwvb05HNTRMTzY1S0prcHllcDdEUUhZeXVUQUd6RFQxM2hRa0RnNGhCRGhEcnY1In0=
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Carsey, Jaben
> Sent: Thursday, August 1, 2019 10:45 PM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
>=20
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>=20
> Thanks
> -Jaben
>=20
>=20
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Bob Feng
> > Sent: Thursday, August 01, 2019 6:24 AM
> > To: devel@edk2.groups.io
> > Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
> > <bob.c.feng@intel.com>
> > Subject: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> >
> > This is a regression issue introduced
> > by commit 307e1650be267b67db7be1089e0979ace460d83
> >
> > This patch is to fix this issue.
> >
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> > ---
> >  BaseTools/Source/Python/Trim/Trim.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Source/Python/Trim/Trim.py
> > b/BaseTools/Source/Python/Trim/Trim.py
> > index 8767b67f7e..24c3fafa76 100644
> > --- a/BaseTools/Source/Python/Trim/Trim.py
> > +++ b/BaseTools/Source/Python/Trim/Trim.py
> > @@ -73,11 +73,11 @@ def TrimPreprocessedFile(Source, Target,
> > ConvertHex, TrimLong):
> >      try:
> >          with open(Source, "r") as File:
> >              Lines =3D File.readlines()
> >      except IOError:
> >          EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=3DSource=
)
> > -    expect:
> > +    except:
> >          EdkLogger.error("Trim", AUTOGEN_ERROR, "TrimPreprocessedFile:=
 Error
> > while processing file", File=3DSource)
> >
> >      PreprocessedFile =3D ""
> >      InjectedFile =3D ""
> >      LineIndexOfOriginalFile =3D None
> > --
> > 2.18.0.windows.1
> >
> >
> >=20