Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py

["Liming Gao" <liming.gao@intel.com>]

push@ 83d6207f99021ac9b2990fc9d66bab3cb3ae5f26

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao
> Sent: Friday, August 2, 2019 12:13 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
> Subject: Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> 
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> > -----Original Message-----
> > From: Carsey, Jaben
> > Sent: Thursday, August 1, 2019 10:45 PM
> > To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
> > Cc: Gao, Liming <liming.gao@intel.com>
> > Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> >
> > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> >
> > Thanks
> > -Jaben
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > > Bob Feng
> > > Sent: Thursday, August 01, 2019 6:24 AM
> > > To: devel@edk2.groups.io
> > > Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
> > > <bob.c.feng@intel.com>
> > > Subject: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> > >
> > > This is a regression issue introduced
> > > by commit 307e1650be267b67db7be1089e0979ace460d83
> > >
> > > This patch is to fix this issue.
> > >
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> > > ---
> > >  BaseTools/Source/Python/Trim/Trim.py | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/BaseTools/Source/Python/Trim/Trim.py
> > > b/BaseTools/Source/Python/Trim/Trim.py
> > > index 8767b67f7e..24c3fafa76 100644
> > > --- a/BaseTools/Source/Python/Trim/Trim.py
> > > +++ b/BaseTools/Source/Python/Trim/Trim.py
> > > @@ -73,11 +73,11 @@ def TrimPreprocessedFile(Source, Target,
> > > ConvertHex, TrimLong):
> > >      try:
> > >          with open(Source, "r") as File:
> > >              Lines = File.readlines()
> > >      except IOError:
> > >          EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> > > -    expect:
> > > +    except:
> > >          EdkLogger.error("Trim", AUTOGEN_ERROR, "TrimPreprocessedFile: Error
> > > while processing file", File=Source)
> > >
> > >      PreprocessedFile = ""
> > >      InjectedFile = ""
> > >      LineIndexOfOriginalFile = None
> > > --
> > > 2.18.0.windows.1
> > >
> > >
> > >
> 
> 
>