From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 01 Aug 2019 09:27:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 09:27:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,334,1559545200"; d="scan'208";a="163666831" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2019 09:27:03 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 09:27:01 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 09:27:01 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Fri, 2 Aug 2019 00:26:58 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Liming" , "Carsey, Jaben" , "Feng, Bob C" Subject: Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py Thread-Topic: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py Thread-Index: AQHVSGxd0wkipS4LDU+EyGeYUEM84abl2FqAgACe3ICAAAPFkA== Date: Thu, 1 Aug 2019 16:26:58 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C7871@SHSMSX104.ccr.corp.intel.com> References: <20190801132343.10628-1-bob.c.feng@intel.com> <15B6D88ADF05C073.3315@groups.io> In-Reply-To: <15B6D88ADF05C073.3315@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTc0N2I0MzMtY2E5YS00MzVlLWE0MjYtMmU2MWJjODQ2MDE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibEw0M2ZSNXFFS09oclVcL0MrcFwvb05HNTRMTzY1S0prcHllcDdEUUhZeXVUQUd6RFQxM2hRa0RnNGhCRGhEcnY1In0= dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable push@ 83d6207f99021ac9b2990fc9d66bab3cb3ae5f26 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Li= ming Gao > Sent: Friday, August 2, 2019 12:13 AM > To: Carsey, Jaben ; devel@edk2.groups.io; Feng, = Bob C > Subject: Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py >=20 > Reviewed-by: Liming Gao >=20 > > -----Original Message----- > > From: Carsey, Jaben > > Sent: Thursday, August 1, 2019 10:45 PM > > To: devel@edk2.groups.io; Feng, Bob C > > Cc: Gao, Liming > > Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py > > > > Reviewed-by: Jaben Carsey > > > > Thanks > > -Jaben > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf O= f > > > Bob Feng > > > Sent: Thursday, August 01, 2019 6:24 AM > > > To: devel@edk2.groups.io > > > Cc: Gao, Liming ; Feng, Bob C > > > > > > Subject: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py > > > > > > This is a regression issue introduced > > > by commit 307e1650be267b67db7be1089e0979ace460d83 > > > > > > This patch is to fix this issue. > > > > > > Cc: Liming Gao > > > Signed-off-by: Bob Feng > > > --- > > > BaseTools/Source/Python/Trim/Trim.py | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/BaseTools/Source/Python/Trim/Trim.py > > > b/BaseTools/Source/Python/Trim/Trim.py > > > index 8767b67f7e..24c3fafa76 100644 > > > --- a/BaseTools/Source/Python/Trim/Trim.py > > > +++ b/BaseTools/Source/Python/Trim/Trim.py > > > @@ -73,11 +73,11 @@ def TrimPreprocessedFile(Source, Target, > > > ConvertHex, TrimLong): > > > try: > > > with open(Source, "r") as File: > > > Lines =3D File.readlines() > > > except IOError: > > > EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=3DSour= ce) > > > - expect: > > > + except: > > > EdkLogger.error("Trim", AUTOGEN_ERROR, "TrimPreprocessedFil= e: Error > > > while processing file", File=3DSource) > > > > > > PreprocessedFile =3D "" > > > InjectedFile =3D "" > > > LineIndexOfOriginalFile =3D None > > > -- > > > 2.18.0.windows.1 > > > > > > > > > >=20 >=20 >=20