From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter
Date: Wed, 7 Aug 2019 01:00:14 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C9772@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190806021722.6476-1-shenglei.zhang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing
>description for parameter
>
>The description of parameter Version is missing in comments.
>So add the description.
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>index 0bfb50333777..4df3fa388ddb 100644
>---
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>+++
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>@@ -230,6 +230,7 @@ Decode (
> @param Scratch A temporary scratch buffer that is used to perform the
>decompression.
> This is an optional parameter that may be NULL if the
> required scratch buffer size is 0.
>+ @param Version 1 for UEFI Decompress algoruthm, 2 for Tiano
>Decompess algorithm.
>
> @retval RETURN_SUCCESS Decompression completed successfully, and
> the uncompressed buffer is returned in Destination.
>--
>2.18.0.windows.1
>
>
>
next prev parent reply other threads:[~2019-08-07 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 2:17 [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter Zhang, Shenglei
2019-08-07 1:00 ` Liming Gao [this message]
2019-08-08 0:41 ` [edk2-devel] " Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4C9772@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox