From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 07 Aug 2019 04:38:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 04:38:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,357,1559545200"; d="scan'208";a="203153504" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 07 Aug 2019 04:38:18 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 04:38:18 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 04:38:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Wed, 7 Aug 2019 19:38:16 +0800 From: "Liming Gao" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Justen, Jordan L" , Andrew Fish , "Ni, Ray" Subject: Re: [Patch 4/4] MdePkg/X64/ProcessorBind.h: Fix EmulatorPkg X64 XCODE5 Thread-Topic: [Patch 4/4] MdePkg/X64/ProcessorBind.h: Fix EmulatorPkg X64 XCODE5 Thread-Index: AQHVSOGm+wz1sWbCkE2SZ5nSo3OsT6bvl2yg Date: Wed, 7 Aug 2019 11:38:15 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CBDCB@SHSMSX104.ccr.corp.intel.com> References: <20190802032309.29000-1-michael.d.kinney@intel.com> <20190802032309.29000-5-michael.d.kinney@intel.com> In-Reply-To: <20190802032309.29000-5-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Kinney, Michael D >Sent: Friday, August 02, 2019 11:23 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Justen, Jordan L >; Andrew Fish ; Ni, Ray > >Subject: [Patch 4/4] MdePkg/X64/ProcessorBind.h: Fix EmulatorPkg X64 >XCODE5 > >https://bugzilla.tianocore.org/show_bug.cgi?id=3D2046 > >Make sure all libs that should be dynamically linked >are dynamically linked when XCODE5 compiler is used. >A previous change introduced the following pragma: > > #pragma GCC visibility push (hidden) > >When the EmulatorPkg is built using XCODE5 toolchain >for X64, this pragma is included and it generates a >linker error when building the Unix Host module. This >change uses !defined(__APPLE__) to prevent the use of >this pragma when building EmulatorPkg/Unix/Host. > >Cc: Liming Gao >Cc: Jordan Justen >Cc: Andrew Fish >Cc: Ray Ni >Signed-off-by: Michael D Kinney >--- > MdePkg/Include/X64/ProcessorBind.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/MdePkg/Include/X64/ProcessorBind.h >b/MdePkg/Include/X64/ProcessorBind.h >index b22cb226b0..6f65acd609 100644 >--- a/MdePkg/Include/X64/ProcessorBind.h >+++ b/MdePkg/Include/X64/ProcessorBind.h >@@ -1,7 +1,7 @@ > /** @file > Processor or Compiler specific defines and types x64 (Intel 64, AMD64). > >- Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
>+ Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ >@@ -21,7 +21,7 @@ > #pragma pack() > #endif > >-#if defined(__GNUC__) && defined(__pic__) && !defined(USING_LTO) >+#if defined(__GNUC__) && defined(__pic__) && !defined(USING_LTO) >&& !defined(__APPLE__) > // > // Mark all symbol declarations and references as hidden, meaning they wi= ll > // not be subject to symbol preemption. This allows the compiler to refer= to >-- >2.21.0.windows.1