From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed an issue that build raise exception
Date: Thu, 8 Aug 2019 00:39:06 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CC468@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190802072148.15256-1-bob.c.feng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Friday, August 02, 2019 3:22 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [edk2-devel] [Patch 1/1] BaseTools: Fixed an issue that build raise
>exception
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2047
>
>Build raise exception if there is libraryclass
>missing in dsc file and --pcd build option is used.
>
>Build should report the missing libraryclass but not
>a call stack.
>
>This patch is going to fix it.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/Workspace/DscBuildData.py | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py
>b/BaseTools/Source/Python/Workspace/DscBuildData.py
>index 620e48fa7f59..3ec1a35bfa3f 100644
>--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
>+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
>@@ -1073,17 +1073,14 @@ class DscBuildData(PlatformBuildClassObject):
> if not IsValid:
> EdkLogger.error("build", FORMAT_INVALID, Cause,
>ExtraData="%s.%s" % (TokenSpaceGuidCName, TokenCName))
> GlobalData.BuildOptionPcd[i] = (TokenSpaceGuidCName,
>TokenCName, FieldName, pcdvalue, ("build command options", 1))
>
> if GlobalData.BuildOptionPcd:
>+ inf_objs = [item for item in self._Bdb._CACHE_.values() if item.Arch ==
>self.Arch and item.MetaFile.Ext.lower() == '.inf']
> for pcd in GlobalData.BuildOptionPcd:
> (TokenSpaceGuidCName, TokenCName, FieldName, pcdvalue, _) =
>pcd
>- for BuildData in self._Bdb._CACHE_.values():
>- if BuildData.Arch != self.Arch:
>- continue
>- if BuildData.MetaFile.Ext == '.dec' or BuildData.MetaFile.Ext ==
>'.dsc':
>- continue
>+ for BuildData in inf_objs:
> for key in BuildData.Pcds:
> PcdItem = BuildData.Pcds[key]
> if (TokenSpaceGuidCName, TokenCName) ==
>(PcdItem.TokenSpaceGuidCName, PcdItem.TokenCName) and FieldName
>=="":
> PcdItem.DefaultValue = pcdvalue
> PcdItem.PcdValueFromComm = pcdvalue
>--
>2.20.1.windows.1
>
>
>
prev parent reply other threads:[~2019-08-08 0:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 7:21 [Patch 1/1] BaseTools: Fixed an issue that build raise exception Bob Feng
2019-08-08 0:39 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4CC468@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox