From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by groups.io with SMTP; Wed, 07 Aug 2019 18:09:50 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 17:41:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,358,1559545200"; 
   d="scan'208";a="186184245"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by orsmga002.jf.intel.com with ESMTP; 07 Aug 2019 17:41:25 -0700
Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 7 Aug 2019 17:41:25 -0700
Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by
 FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 7 Aug 2019 17:41:24 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by
 SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000;
 Thu, 8 Aug 2019 08:41:19 +0800
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Zhang, Shenglei"
	<shenglei.zhang@intel.com>
CC: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter
Thread-Topic: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing
 description for parameter
Thread-Index: AQHVS/0b/5RtKdtMRkKvG6LRQycZK6bwa/vQ
Date: Thu, 8 Aug 2019 00:41:18 +0000
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CC479@SHSMSX104.ccr.corp.intel.com>
References: <20190806021722.6476-1-shenglei.zhang@intel.com>
In-Reply-To: <20190806021722.6476-1-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: liming.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing
>description for parameter
>
>The description of parameter Version is missing in comments.
>So add the description.
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h       | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>index 0bfb50333777..4df3fa388ddb 100644
>---
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>+++
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>@@ -230,6 +230,7 @@ Decode (
>   @param  Scratch     A temporary scratch buffer that is used to perform=
 the
>decompression.
>                       This is an optional parameter that may be NULL if =
the
>                       required scratch buffer size is 0.
>+  @param  Version     1 for UEFI Decompress algoruthm, 2 for Tiano
>Decompess algorithm.
>
>   @retval  RETURN_SUCCESS Decompression completed successfully, and
>                           the uncompressed buffer is returned in Destina=
tion.
>--
>2.18.0.windows.1
>
>
>