* [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter
@ 2019-08-06 2:17 Zhang, Shenglei
2019-08-07 1:00 ` [edk2-devel] " Liming Gao
2019-08-08 0:41 ` Liming Gao
0 siblings, 2 replies; 3+ messages in thread
From: Zhang, Shenglei @ 2019-08-06 2:17 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao
The description of parameter Version is missing in comments.
So add the description.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h
index 0bfb50333777..4df3fa388ddb 100644
--- a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h
+++ b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h
@@ -230,6 +230,7 @@ Decode (
@param Scratch A temporary scratch buffer that is used to perform the decompression.
This is an optional parameter that may be NULL if the
required scratch buffer size is 0.
+ @param Version 1 for UEFI Decompress algoruthm, 2 for Tiano Decompess algorithm.
@retval RETURN_SUCCESS Decompression completed successfully, and
the uncompressed buffer is returned in Destination.
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter
2019-08-06 2:17 [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter Zhang, Shenglei
@ 2019-08-07 1:00 ` Liming Gao
2019-08-08 0:41 ` Liming Gao
1 sibling, 0 replies; 3+ messages in thread
From: Liming Gao @ 2019-08-07 1:00 UTC (permalink / raw)
To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Kinney, Michael D
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing
>description for parameter
>
>The description of parameter Version is missing in comments.
>So add the description.
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>index 0bfb50333777..4df3fa388ddb 100644
>---
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>+++
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>@@ -230,6 +230,7 @@ Decode (
> @param Scratch A temporary scratch buffer that is used to perform the
>decompression.
> This is an optional parameter that may be NULL if the
> required scratch buffer size is 0.
>+ @param Version 1 for UEFI Decompress algoruthm, 2 for Tiano
>Decompess algorithm.
>
> @retval RETURN_SUCCESS Decompression completed successfully, and
> the uncompressed buffer is returned in Destination.
>--
>2.18.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter
2019-08-06 2:17 [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter Zhang, Shenglei
2019-08-07 1:00 ` [edk2-devel] " Liming Gao
@ 2019-08-08 0:41 ` Liming Gao
1 sibling, 0 replies; 3+ messages in thread
From: Liming Gao @ 2019-08-08 0:41 UTC (permalink / raw)
To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Kinney, Michael D
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing
>description for parameter
>
>The description of parameter Version is missing in comments.
>So add the description.
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>index 0bfb50333777..4df3fa388ddb 100644
>---
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>+++
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>@@ -230,6 +230,7 @@ Decode (
> @param Scratch A temporary scratch buffer that is used to perform the
>decompression.
> This is an optional parameter that may be NULL if the
> required scratch buffer size is 0.
>+ @param Version 1 for UEFI Decompress algoruthm, 2 for Tiano
>Decompess algorithm.
>
> @retval RETURN_SUCCESS Decompression completed successfully, and
> the uncompressed buffer is returned in Destination.
>--
>2.18.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-08 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-06 2:17 [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter Zhang, Shenglei
2019-08-07 1:00 ` [edk2-devel] " Liming Gao
2019-08-08 0:41 ` Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox