public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable
Date: Thu, 8 Aug 2019 05:46:32 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CC871@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9175F1@SHSMSX104.ccr.corp.intel.com>

PatchCheck reports Trailing whitespace. Please fix it when you push the change. 

* Trailing whitespace found
   File: MdeModulePkg/MdeModulePkg.dec
   Line:   # @Prompt Enable 5-Level Paging support in long mode.
 * Trailing whitespace found
   File: MdeModulePkg/MdeModulePkg.uni
   Line:

Thanks
Liming
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu,
>Hao A
>Sent: Thursday, August 08, 2019 1:30 PM
>To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
>Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>;
>Wang, Jian J <jian.j.wang@intel.com>
>Subject: Re: [edk2-devel] [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce
>PCD PcdUse5LevelPageTable
>
>> -----Original Message-----
>> From: Ni, Ray
>> Sent: Thursday, August 01, 2019 5:58 PM
>> To: devel@edk2.groups.io
>> Cc: Dong, Eric; Laszlo Ersek; Wu, Hao A; Wang, Jian J
>> Subject: [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD
>> PcdUse5LevelPageTable
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2008
>>
>> The PCD indicates if 5-Level Paging will be enabled in long mode.
>> 5-Level Paging will not be enabled when the PCD is TRUE but CPU
>> doesn't support 5-Level Paging.
>>
>> Signed-off-by: Ray Ni <ray.ni@intel.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> ---
>>  MdeModulePkg/MdeModulePkg.dec | 7 +++++++
>>  MdeModulePkg/MdeModulePkg.uni | 8 ++++++++
>>  2 files changed, 15 insertions(+)
>>
>> diff --git a/MdeModulePkg/MdeModulePkg.dec
>> b/MdeModulePkg/MdeModulePkg.dec
>> index 12e0bbf579..21388595a9 100644
>> --- a/MdeModulePkg/MdeModulePkg.dec
>> +++ b/MdeModulePkg/MdeModulePkg.dec
>> @@ -1991,6 +1991,13 @@ [PcdsFixedAtBuild, PcdsPatchableInModule,
>> PcdsDynamic, PcdsDynamicEx]
>>    # @Prompt The address mask when memory encryption is enabled.
>>
>>
>gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrM
>> ask|0x0|UINT64|0x30001047
>>
>> +  ## Indicates if 5-Level Paging will be enabled in long mode. 5-Level Paging
>> will not be enabled
>> +  #  when the PCD is TRUE but CPU doesn't support 5-Level Paging.
>> +  #   TRUE  - 5-Level Paging will be enabled.<BR>
>> +  #   FALSE - 5-Level Paging will not be enabled.<BR>
>> +  # @Prompt Enable 5-Level Paging support in long mode.
>> +
>>
>gEfiMdeModulePkgTokenSpaceGuid.PcdUse5LevelPageTable|FALSE|BOOLE
>> AN|0x0001105F
>> +
>>    ## Capsule In Ram is to use memory to deliver the capsules that will be
>> processed after system
>>    #  reset.<BR><BR>
>>    #  This PCD indicates if the Capsule In Ram is supported.<BR>
>> diff --git a/MdeModulePkg/MdeModulePkg.uni
>> b/MdeModulePkg/MdeModulePkg.uni
>> index 2bd1ad29f2..3a1c88e4c5 100644
>> --- a/MdeModulePkg/MdeModulePkg.uni
>> +++ b/MdeModulePkg/MdeModulePkg.uni
>> @@ -1298,3 +1298,11 @@
>>                                                                                     "It is used to set VPD region base
>> address. So, it can't be DynamicExVpd PCD. Its value is"
>>                                                                                     "required to be accessed in
>PcdDxe
>> driver entry point. So, its value must be set in PEI phase."
>>                                                                                     "It can't depend on EFI variable
>> service, and can't be DynamicExHii PCD."
>> +
>> +#string
>> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdUse5LevelPageTable_PROMP
>> T  #language en-US "Enable 5-Level Paging support in long mode"
>> +
>> +#string
>> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdUse5LevelPageTable_HELP
>> #language en-US "Indicates if 5-Level Paging will be enabled in long mode. 5-
>> Level Paging will not be enabled"
>> +                                                                                    "when the PCD is TRUE but CPU
>> doesn't support 5-Level Paging."
>> +                                                                                    " TRUE  - 5-Level Paging will be
>> enabled."
>> +                                                                                    " FALSE - 5-Level Paging will not
>be
>> enabled."
>> +
>
>
>Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
>
>Best Regards,
>Hao Wu
>
>
>> --
>> 2.21.0.windows.1
>
>
>


  reply	other threads:[~2019-08-08  5:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01  9:58 [PATCH v4 0/8] Support 5-level paging in DXE long mode Ni, Ray
2019-08-01  9:58 ` [PATCH v4 1/8] UefiCpuPkg/MpInitLib: Enable 5-level paging for AP when BSP's enabled Ni, Ray
2019-08-02  1:08   ` Dong, Eric
2019-08-01  9:58 ` [PATCH v4 2/8] UefiCpuPkg/CpuDxe: Remove unnecessary macros Ni, Ray
2019-08-02  1:13   ` Dong, Eric
2019-08-01  9:58 ` [PATCH v4 3/8] UefiCpuPkg/CpuDxe: Support parsing 5-level page table Ni, Ray
2019-08-02  1:20   ` Dong, Eric
2019-08-01  9:58 ` [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable Ni, Ray
2019-08-02  1:22   ` Dong, Eric
2019-08-08  5:30   ` Wu, Hao A
2019-08-08  5:46     ` Liming Gao [this message]
2019-08-01  9:58 ` [PATCH v4 5/8] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Ni, Ray
2019-08-02  1:28   ` Dong, Eric
2019-08-08  3:03   ` Liming Gao
2019-08-01  9:58 ` [PATCH v4 6/8] MdeModulePkg/DxeIpl: Create 5-level page table for long mode Ni, Ray
2019-08-02  2:23   ` Dong, Eric
2019-08-08  5:34   ` Wu, Hao A
2019-08-01  9:58 ` [PATCH v4 7/8] UefiCpuPkg|MdePkg: Move Register/ folder to MdePkg/Include/ Ni, Ray
2019-08-02  2:25   ` Dong, Eric
2019-08-08  3:06   ` Liming Gao
2019-08-01  9:58 ` [PATCH v4 8/8] UefiCpuPkg: Update code to include register definitions from MdePkg Ni, Ray
2019-08-02  2:29   ` Dong, Eric
2019-08-07 20:18 ` [edk2-devel] [PATCH v4 0/8] Support 5-level paging in DXE long mode Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4CC871@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox