From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Wed, 07 Aug 2019 22:46:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 22:46:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="168872851" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 07 Aug 2019 22:46:35 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 22:46:35 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 22:46:35 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 13:46:33 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Ni, Ray" CC: "Dong, Eric" , Laszlo Ersek , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable Thread-Topic: [edk2-devel] [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD PcdUse5LevelPageTable Thread-Index: AQHVSE/PbTtqummYaEOOnl9vVyvncKbwPfaAgACKbaA= Date: Thu, 8 Aug 2019 05:46:32 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CC871@SHSMSX104.ccr.corp.intel.com> References: <20190801095831.274356-1-ray.ni@intel.com> <20190801095831.274356-5-ray.ni@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable PatchCheck reports Trailing whitespace. Please fix it when you push the cha= nge.=20 * Trailing whitespace found File: MdeModulePkg/MdeModulePkg.dec Line: # @Prompt Enable 5-Level Paging support in long mode. * Trailing whitespace found File: MdeModulePkg/MdeModulePkg.uni Line: Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, >Hao A >Sent: Thursday, August 08, 2019 1:30 PM >To: Ni, Ray ; devel@edk2.groups.io >Cc: Dong, Eric ; Laszlo Ersek ; >Wang, Jian J >Subject: Re: [edk2-devel] [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce >PCD PcdUse5LevelPageTable > >> -----Original Message----- >> From: Ni, Ray >> Sent: Thursday, August 01, 2019 5:58 PM >> To: devel@edk2.groups.io >> Cc: Dong, Eric; Laszlo Ersek; Wu, Hao A; Wang, Jian J >> Subject: [PATCH v4 4/8] MdeModulePkg/DxeIpl: Introduce PCD >> PcdUse5LevelPageTable >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2008 >> >> The PCD indicates if 5-Level Paging will be enabled in long mode. >> 5-Level Paging will not be enabled when the PCD is TRUE but CPU >> doesn't support 5-Level Paging. >> >> Signed-off-by: Ray Ni >> Cc: Eric Dong >> Cc: Laszlo Ersek >> Cc: Hao A Wu >> Cc: Jian J Wang >> --- >> MdeModulePkg/MdeModulePkg.dec | 7 +++++++ >> MdeModulePkg/MdeModulePkg.uni | 8 ++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/MdeModulePkg/MdeModulePkg.dec >> b/MdeModulePkg/MdeModulePkg.dec >> index 12e0bbf579..21388595a9 100644 >> --- a/MdeModulePkg/MdeModulePkg.dec >> +++ b/MdeModulePkg/MdeModulePkg.dec >> @@ -1991,6 +1991,13 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, >> PcdsDynamic, PcdsDynamicEx] >> # @Prompt The address mask when memory encryption is enabled. >> >> >gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrM >> ask|0x0|UINT64|0x30001047 >> >> + ## Indicates if 5-Level Paging will be enabled in long mode. 5-Level= Paging >> will not be enabled >> + # when the PCD is TRUE but CPU doesn't support 5-Level Paging. >> + # TRUE - 5-Level Paging will be enabled.
>> + # FALSE - 5-Level Paging will not be enabled.
>> + # @Prompt Enable 5-Level Paging support in long mode. >> + >> >gEfiMdeModulePkgTokenSpaceGuid.PcdUse5LevelPageTable|FALSE|BOOLE >> AN|0x0001105F >> + >> ## Capsule In Ram is to use memory to deliver the capsules that will= be >> processed after system >> # reset.

>> # This PCD indicates if the Capsule In Ram is supported.
>> diff --git a/MdeModulePkg/MdeModulePkg.uni >> b/MdeModulePkg/MdeModulePkg.uni >> index 2bd1ad29f2..3a1c88e4c5 100644 >> --- a/MdeModulePkg/MdeModulePkg.uni >> +++ b/MdeModulePkg/MdeModulePkg.uni >> @@ -1298,3 +1298,11 @@ >> = "It is used to set VPD region base >> address. So, it can't be DynamicExVpd PCD. Its value is" >> = "required to be accessed in >PcdDxe >> driver entry point. So, its value must be set in PEI phase." >> = "It can't depend on EFI variable >> service, and can't be DynamicExHii PCD." >> + >> +#string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdUse5LevelPageTable_PROMP >> T #language en-US "Enable 5-Level Paging support in long mode" >> + >> +#string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdUse5LevelPageTable_HELP >> #language en-US "Indicates if 5-Level Paging will be enabled in long mo= de. 5- >> Level Paging will not be enabled" >> + = "when the PCD is TRUE but CPU >> doesn't support 5-Level Paging." >> + = " TRUE - 5-Level Paging will be >> enabled." >> + = " FALSE - 5-Level Paging will not >be >> enabled." >> + > > >Reviewed-by: Hao A Wu > >Best Regards, >Hao Wu > > >> -- >> 2.21.0.windows.1 > > >