From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Wed, 07 Aug 2019 23:34:43 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 23:34:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="179746030" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 07 Aug 2019 23:34:42 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 23:34:42 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 7 Aug 2019 23:34:41 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.80]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 14:34:40 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Bi, Dandan" , "Jin, Eric" Subject: Re: [edk2-devel] [PATCH 00/14] Multiple Controllers Support solution Thread-Topic: [edk2-devel] [PATCH 00/14] Multiple Controllers Support solution Thread-Index: AQHVSESXrwooz/RrTEeOgy+wENKdPKbtRkcAgANZbKA= Date: Thu, 8 Aug 2019 06:34:39 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CC979@SHSMSX104.ccr.corp.intel.com> References: <20190801083847.14524-1-eric.jin@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB40C3BBF3@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40C3BBF3@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Eric: I review this patch set. I think patch 14 can be merged into patch 4, p= atch 13 can be merged into patch 5.=20 And, patch 2 introduces new APIs in FmpDeviceLib. I see edk2-platform Pl= atform\Intel\Vlv2TbltDevicePkg\Feature\Capsule\Library\FmpDeviceLib=20 is the FmpDeviceLib library instance. Have you the patch to update it to= support new APIs? Last, ECC reports some issues. Please make sure they be fixed in next ve= rsion.=20 "All include file contents should be guarded by a #ifndef statement.",FmpD= evicePkg\CapsuleUpdatePolicyDxe\CapsuleUpdatePolicyDxe.h,1,"" FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLib.c,71,"in Comment, <@par= am[in, out]> does NOT have [out] " FmpDevicePkg\Include\Library\FmpDeviceLib.h,107,"in Comment, <@param[in, o= ut]> does NOT have [out] " FmpDevicePkg\FmpDxe\FmpDxe.c,202,"No doxygen tags in comment " FmpDevicePkg\FmpDxe\FmpDxe.c,261,"No doxygen tags in comment " Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Dandan Bi >Sent: Tuesday, August 06, 2019 4:11 PM >To: devel@edk2.groups.io; Jin, Eric >Subject: Re: [edk2-devel] [PATCH 00/14] Multiple Controllers Support solu= tion > >Hi Eric, > >This patch series also can be consolidated to a smaller patch set. >Please help double check. > > >Thanks, >Dandan > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Eric Jin >> Sent: Thursday, August 1, 2019 4:39 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH 00/14] Multiple Controllers Support soluti= on >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1525 >> >> The patch set is to support drivers that manage multiple controllers an= d also >> provide a firmware update capability to each managed controller. >> >> The following modules are related to Multiple Controllers Support solut= ion >> >> FmpDevicePkg\FmpDxe\FmpDxe.inf - Driver to manage multiple controllers >> and provide the firmware update capability to each managed controller. >> FmpDevicePkg\CapsuleUpdatePolicyDxe\CapsuleUpdatePolicyDxe.inf - >> Driver to produce the Capsule Update Policy Protocol using the services= of >> the CapsuleUpdatePolicyLib class. The protocol is a private interface t= o the >> FmpDevicePkg >> >FmpDevicePkg\Library\CapsuleUpdatePolicyLibOnProtocol\CapsuleUpdateP >> olicyLibOnProtocol.inf - CapsuleUpdatePolicyLib instance that uses the >> services of the Capsule Update Policy Protocol produced by >> CapsuleUpdatePolicyDxe >> FmpDevicePkg\Library\CapsuleUpdatePolicyLibNull\CapsuleUpdatePolicyLib >> Null.inf - Null CapsuleUpdatePolicyLib instance and the template for >platform >> specific implementation >> FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLibNull.inf - Null >> FmpDeviceLib instance and the template for platform specific >> implementation >> >> >> Eric Jin (14): >> FmpDevicePkg: Add UEFI_DRIVER support >> FmpDevicePkg: Add APIs to FmpDeviceLib >> FmpDEvicePkg/FmpDeviceLibNull: Implement new APIs >> FmpDevicePkg/FmpDxe: Use new FmpDeviceLib APIs >> FmpDevicePkg/FmpDxe: Different variable for each FMP Descriptor >> FmpDevicePkg: Add Capsule Update Policy Protocol >> FmpDevicePkg/FmpDxe: Improve all DEBUG() messages >> FmpDevicePkg/FmpDxe: Add PcdFmpDeviceImageTypeIdGuid >> FmpDevicePkg/FmpDxe: Add PcdFmpDeviceStorageAccessEnable >> FmpDevicePkg/FmpDxe: Remove use of CatSprint() >> FmpDevicePkg/FmpDxe: Fix SetLowestSupportedVersionInVariable() >> FmpDevicePkg/FmpDxe: Change where FmpControllerState is updated >> FmpDevicePkg/FmpDxe: Fix code indent >> FmpDevicePkg/FmpDxe: Add FmpDxe.h to [Sources] >> >> .../CapsuleUpdatePolicyDxe.c | 173 ++++ >> .../CapsuleUpdatePolicyDxe.h | 135 +++ >> .../CapsuleUpdatePolicyDxe.inf | 48 + >> .../CapsuleUpdatePolicyDxe.uni | 14 + >> .../CapsuleUpdatePolicyDxeExtra.uni | 14 + >> FmpDevicePkg/FmpDevicePkg.dec | 43 +- >> FmpDevicePkg/FmpDevicePkg.dsc | 64 +- >> FmpDevicePkg/FmpDevicePkg.uni | 16 +- >> FmpDevicePkg/FmpDxe/DetectTestKey.c | 16 +- >> FmpDevicePkg/FmpDxe/FmpDxe.c | 787 ++++++++++------ >> FmpDevicePkg/FmpDxe/FmpDxe.h | 355 ++++++++ >> FmpDevicePkg/FmpDxe/FmpDxe.inf | 7 +- >> FmpDevicePkg/FmpDxe/FmpDxeLib.inf | 7 +- >> FmpDevicePkg/FmpDxe/VariableSupport.c | 844 +++++++++++++----- >> FmpDevicePkg/FmpDxe/VariableSupport.h | 135 ++- >> FmpDevicePkg/Include/Library/FmpDeviceLib.h | 104 ++- >> .../CapsuleUpdatePolicyLibOnProtocol.c | 171 ++++ >> .../CapsuleUpdatePolicyLibOnProtocol.inf | 40 + >> .../CapsuleUpdatePolicyLibOnProtocol.uni | 15 + >> .../Library/FmpDeviceLibNull/FmpDeviceLib.c | 93 +- >> .../FmpDeviceLibNull/FmpDeviceLibNull.inf | 4 +- >> .../FmpPayloadHeaderLibV1.inf | 4 +- >> .../Library/FmpPayloadHeaderLib.h | 0 >> .../Protocol/CapsuleUpdatePolicy.h | 132 +++ >> 24 files changed, 2635 insertions(+), 586 deletions(-) >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.h >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.inf >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.uni >> create mode 100644 >> FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxeExtra.uni >> create mode 100644 FmpDevicePkg/FmpDxe/FmpDxe.h >> create mode 100644 >> >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >> olicyLibOnProtocol.c >> create mode 100644 >> >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >> olicyLibOnProtocol.inf >> create mode 100644 >> >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdateP >> olicyLibOnProtocol.uni >> rename FmpDevicePkg/{Include =3D> >> PrivateInclude}/Library/FmpPayloadHeaderLib.h (100%) >> create mode 100644 >> FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h >> >> -- >> 2.20.1.windows.1 >> >> >> > > >