From: "Liming Gao" <liming.gao@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Eugene Cohen <eugene@hp.com>
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template
Date: Thu, 8 Aug 2019 10:51:54 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CCBDA@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190808095518.GT25813@bivouac.eciton.net>
Leif:
>-----Original Message-----
>From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>Sent: Thursday, August 08, 2019 5:55 PM
>To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
>Eugene Cohen <eugene@hp.com>
>Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in
>tools_def.template
>
>Hi Shenglei,
>
>On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote:
>> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35
>> in tools_def.template. These tool chains are for ARM and AARCH64 only.
>> There is no change recently and they are not used.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1750
>
>This still does not address my comment in the BZ that deleting all
>RVCT profiles before full VS support is enabled for (32-bit) ARM, we
>orphan an awful lot of .asm files.
>
How about submit another BZ for VS tool chain ARM fully support?
When there is real request, this support can be added in future.
>This may not have much of a practical effect, since I doubt anyone is
>using these toolchains today - but it does prevent someone from
>actively going through and testing future updates (where before, they
>may just have neglected to do so).
>
>This point needs discussing rather than ignoring, and I think we're
>getting too close to the freeze to consider the patch to go in as is
>at this point.
>
Agree for more discussion.
>Whenever this patch does go in should be in the week after a stable
>tag is made, to give plenty of time for anyone affected to shout
>before the next stable tag is made.
>
>After the 2019.08 stable tag has been made, I am happy for a patch
>going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX.
>
If no one maintain or use it, this tool chain may not work now.
If so, do we still need to keep it?
Thanks
Liming
>The deletion of the final RVCT profile needs further discussion.
>
>Best Regards,
>
>Leif
next prev parent reply other threads:[~2019-08-08 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 8:09 [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template Zhang, Shenglei
2019-08-08 9:55 ` [edk2-devel] " Leif Lindholm
2019-08-08 10:51 ` Liming Gao [this message]
2019-08-08 11:30 ` Leif Lindholm
2019-08-08 20:46 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4CCBDA@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox