From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 08 Aug 2019 03:51:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 03:51:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="174814547" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 08 Aug 2019 03:51:58 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 8 Aug 2019 03:51:57 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 8 Aug 2019 03:51:56 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Thu, 8 Aug 2019 18:51:55 +0800 From: "Liming Gao" To: Leif Lindholm , "devel@edk2.groups.io" , "Zhang, Shenglei" CC: "Feng, Bob C" , Ard Biesheuvel , Eugene Cohen Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template Thread-Index: AQHVTcCag4hVTjOjPka2bbhxPdA9YabwfScAgACTL2A= Date: Thu, 8 Aug 2019 10:51:54 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CCBDA@SHSMSX104.ccr.corp.intel.com> References: <20190808080918.744-1-shenglei.zhang@intel.com> <20190808095518.GT25813@bivouac.eciton.net> In-Reply-To: <20190808095518.GT25813@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif: >-----Original Message----- >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >Sent: Thursday, August 08, 2019 5:55 PM >To: devel@edk2.groups.io; Zhang, Shenglei >Cc: Feng, Bob C ; Gao, Liming >; Ard Biesheuvel ; >Eugene Cohen >Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in >tools_def.template > >Hi Shenglei, > >On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote: >> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35 >> in tools_def.template. These tool chains are for ARM and AARCH64 only. >> There is no change recently and they are not used. >> https://bugzilla.tianocore.org/show_bug.cgi?id=3D1750 > >This still does not address my comment in the BZ that deleting all >RVCT profiles before full VS support is enabled for (32-bit) ARM, we >orphan an awful lot of .asm files. > How about submit another BZ for VS tool chain ARM fully support?=20 When there is real request, this support can be added in future.=20 >This may not have much of a practical effect, since I doubt anyone is >using these toolchains today - but it does prevent someone from >actively going through and testing future updates (where before, they >may just have neglected to do so). > >This point needs discussing rather than ignoring, and I think we're >getting too close to the freeze to consider the patch to go in as is >at this point. > Agree for more discussion.=20 >Whenever this patch does go in should be in the week after a stable >tag is made, to give plenty of time for anyone affected to shout >before the next stable tag is made. > >After the 2019.08 stable tag has been made, I am happy for a patch >going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX. > If no one maintain or use it, this tool chain may not work now.=20 If so, do we still need to keep it? Thanks Liming >The deletion of the final RVCT profile needs further discussion. > >Best Regards, > >Leif