Re: [edk2-devel] [PATCH v4 00/15] MdeModulePkg: Transfer reset data

["Liming Gao" <liming.gao@intel.com>]

Zhichao:
  The change looks good. I have one comment to add more descriptions for new introduced two guids. 
  If so, the developer knows how to use them. 

  Besides, if this patch is for 201908 stable tag, please send RFC for this feature to announce@edk2.groups.io and devel@edk2.groups.io to collect feedbacks. 

Thanks
Liming
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Gao, Zhichao
>Sent: Monday, August 12, 2019 11:08 AM
>To: devel@edk2.groups.io
>Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
>Ni, Ray <ray.ni@intel.com>; Zeng, Star <star.zeng@intel.com>; Laszlo Ersek
><lersek@redhat.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif
>Lindholm <leif.lindholm@linaro.org>; Justen, Jordan L
><jordan.l.justen@intel.com>; Ma, Maurice <maurice.ma@intel.com>; Dong,
>Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>; Gao,
>Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
>Michael Turner <Michael.Turner@microsoft.com>; Bret Barkelew
><Bret.Barkelew@microsoft.com>; Chiu, Chasel <chasel.chiu@intel.com>
>Subject: [edk2-devel] [PATCH v4 00/15] MdeModulePkg: Transfer reset data
>
>Indicate two guids gCapsuleArmedResetGuid and
>gCapsuleUpdateCompleteResetGuid
>for capsule update. And define a struct which start with a null string and
>followed by a EFI_GUID.
>
>V2:
>Add prefix Edkii to the new guids.
>Move the new struct definition to ResetSystemLib.h.
>Fix the wrong reset data to transfer.
>Fix the comment of EfiResetSystem in RuntimeLib base on UEFI spec 2.8.
>
>V3:
>Drop 'Move the new struct definition to ResetSystemLib.h.' because the
>structure
>would be only used in ResetUtilityLib
>Using the API ResetSystemWithSubtype in ResetUtilityLib to transfer
>a single GUID reset data.
>Add ResetUtilityLib to the dsc files that contain CapsuleRuntimeDxe and
>CapsuleLib (DxeCapsuleLib instance).
>
>V4:
>Format git config to show the [] section.
>Fixed incorrect location of ResetUtilityLib in OvmfPkgIa32X64.dsc.
>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Hao Wu <hao.a.wu@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Cc: Laszlo Ersek <lersek@redhat.com>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: Jordan Justen <jordan.l.justen@intel.com>
>Cc: Maurice Ma <maurice.ma@intel.com>
>Cc: Guo Dong <guo.dong@intel.com>
>Cc: Benjamin You <benjamin.you@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Sean Brogan <sean.brogan@microsoft.com>
>Cc: Michael Turner <Michael.Turner@microsoft.com>
>Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>Cc: Chasel Chiu <chasel.chiu@intel.com>
>Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
>
>
>Bret Barkelew (3):
>  MdeModulePkg: Add guids for capsule update
>  MdeModulePkg/CapsuleRuntimeDxe: Transfer reset data
>  MdeModulePkg/CapsuleLib: Transfer reset data
>
>Zhichao Gao (12):
>  MdeModulePkg: Add ResetUtilityLib to dsc file
>  ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file
>  ArmVritPkg/ArmVirtQemuKernel.dsc: Add ResetUtilityLib to dsc file
>  ArmVirtPkg/ArmVirtXen.dsc: Add ResetUtilityLib to dsc file
>  EmulatorPkg/EmulatorPkg.dsc: Add ResetUtilityLib to dsc file
>  OvmfPkg/OvmfPkgIa32.dsc: Add ResetUtilityLib to dsc file
>  OvmfPkg/OvmfPkgIa32X64.dsc: Add ResetUtilityLib to dsc file
>  OvmfPkg/OvmfPkgX64.dsc: Add ResetUtilityLib to dsc file
>  UefiPayloadPkg/UefiPayloadPkgIa32.dsc: Add ResetUtilityLib to dsc file
>  UefiPayloadPkg: Add ResetUtilityLib to UefiPayloadPkgIa32X64.dsc
>  MdePkg/UefiRuntimeLib.h: Change the comment
>  MdePkg/UefiRuntimeLib: Change the comment
>
> ArmVirtPkg/ArmVirtQemu.dsc                                | 1 +
> ArmVirtPkg/ArmVirtQemuKernel.dsc                          | 1 +
> ArmVirtPkg/ArmVirtXen.dsc                                 | 1 +
> EmulatorPkg/EmulatorPkg.dsc                               | 1 +
> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf   | 2 ++
> .../Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c       | 3 ++-
> MdeModulePkg/MdeModulePkg.dec                             | 4 ++++
> MdeModulePkg/MdeModulePkg.dsc                             | 1 +
> .../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf     | 2 ++
> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c | 2 +-
> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h | 3 ++-
> MdePkg/Include/Library/UefiRuntimeLib.h                   | 8 ++++----
> MdePkg/Library/UefiRuntimeLib/RuntimeLib.c                | 8 ++++----
> OvmfPkg/OvmfPkgIa32.dsc                                   | 2 ++
> OvmfPkg/OvmfPkgIa32X64.dsc                                | 1 +
> OvmfPkg/OvmfPkgX64.dsc                                    | 2 ++
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc                     | 2 ++
> UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc                  | 2 ++
> 18 files changed, 35 insertions(+), 11 deletions(-)
>
>--
>2.21.0.windows.1
>
>
>