From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Sun, 11 Aug 2019 22:10:58 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 22:10:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,376,1559545200"; d="scan'208";a="183457112" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 11 Aug 2019 22:10:58 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 22:10:58 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 22:10:57 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 13:10:55 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Zeng, Star" , "Laszlo Ersek" , Ard Biesheuvel , "Leif Lindholm" , "Justen, Jordan L" , "Ma, Maurice" , "Dong, Guo" , "You, Benjamin" , "Kinney, Michael D" , Sean Brogan , Michael Turner , Bret Barkelew , "Chiu, Chasel" Subject: Re: [edk2-devel] [PATCH v4 00/15] MdeModulePkg: Transfer reset data Thread-Topic: [edk2-devel] [PATCH v4 00/15] MdeModulePkg: Transfer reset data Thread-Index: AQHVULsq+C8Ew66WD0iONdZZkpRNeKb29Lzg Date: Mon, 12 Aug 2019 05:10:54 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CE81A@SHSMSX104.ccr.corp.intel.com> References: <20190812030758.10324-1-zhichao.gao@intel.com> In-Reply-To: <20190812030758.10324-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao: The change looks good. I have one comment to add more descriptions for n= ew introduced two guids.=20 If so, the developer knows how to use them.=20 Besides, if this patch is for 201908 stable tag, please send RFC for thi= s feature to announce@edk2.groups.io and devel@edk2.groups.io to collect fe= edbacks.=20 Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Gao, Zhichao >Sent: Monday, August 12, 2019 11:08 AM >To: devel@edk2.groups.io >Cc: Wang, Jian J ; Wu, Hao A ; >Ni, Ray ; Zeng, Star ; Laszlo Erse= k >; Ard Biesheuvel ; Leif >Lindholm ; Justen, Jordan L >; Ma, Maurice ; Dong, >Guo ; You, Benjamin ; Gao, >Liming ; Kinney, Michael D >; Sean Brogan ; >Michael Turner ; Bret Barkelew >; Chiu, Chasel >Subject: [edk2-devel] [PATCH v4 00/15] MdeModulePkg: Transfer reset data > >Indicate two guids gCapsuleArmedResetGuid and >gCapsuleUpdateCompleteResetGuid >for capsule update. And define a struct which start with a null string an= d >followed by a EFI_GUID. > >V2: >Add prefix Edkii to the new guids. >Move the new struct definition to ResetSystemLib.h. >Fix the wrong reset data to transfer. >Fix the comment of EfiResetSystem in RuntimeLib base on UEFI spec 2.8. > >V3: >Drop 'Move the new struct definition to ResetSystemLib.h.' because the >structure >would be only used in ResetUtilityLib >Using the API ResetSystemWithSubtype in ResetUtilityLib to transfer >a single GUID reset data. >Add ResetUtilityLib to the dsc files that contain CapsuleRuntimeDxe and >CapsuleLib (DxeCapsuleLib instance). > >V4: >Format git config to show the [] section. >Fixed incorrect location of ResetUtilityLib in OvmfPkgIa32X64.dsc. > >Cc: Jian J Wang >Cc: Hao Wu >Cc: Ray Ni >Cc: Star Zeng >Cc: Laszlo Ersek >Cc: Ard Biesheuvel >Cc: Leif Lindholm >Cc: Jordan Justen >Cc: Maurice Ma >Cc: Guo Dong >Cc: Benjamin You >Cc: Liming Gao >Cc: Michael D Kinney >Cc: Sean Brogan >Cc: Michael Turner >Cc: Bret Barkelew >Cc: Chasel Chiu >Signed-off-by: Zhichao Gao > > >Bret Barkelew (3): > MdeModulePkg: Add guids for capsule update > MdeModulePkg/CapsuleRuntimeDxe: Transfer reset data > MdeModulePkg/CapsuleLib: Transfer reset data > >Zhichao Gao (12): > MdeModulePkg: Add ResetUtilityLib to dsc file > ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file > ArmVritPkg/ArmVirtQemuKernel.dsc: Add ResetUtilityLib to dsc file > ArmVirtPkg/ArmVirtXen.dsc: Add ResetUtilityLib to dsc file > EmulatorPkg/EmulatorPkg.dsc: Add ResetUtilityLib to dsc file > OvmfPkg/OvmfPkgIa32.dsc: Add ResetUtilityLib to dsc file > OvmfPkg/OvmfPkgIa32X64.dsc: Add ResetUtilityLib to dsc file > OvmfPkg/OvmfPkgX64.dsc: Add ResetUtilityLib to dsc file > UefiPayloadPkg/UefiPayloadPkgIa32.dsc: Add ResetUtilityLib to dsc file > UefiPayloadPkg: Add ResetUtilityLib to UefiPayloadPkgIa32X64.dsc > MdePkg/UefiRuntimeLib.h: Change the comment > MdePkg/UefiRuntimeLib: Change the comment > > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > ArmVirtPkg/ArmVirtXen.dsc | 1 + > EmulatorPkg/EmulatorPkg.dsc | 1 + > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 2 ++ > .../Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 3 ++- > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > .../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 2 ++ > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c | 2 +- > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h | 3 ++- > MdePkg/Include/Library/UefiRuntimeLib.h | 8 ++++---- > MdePkg/Library/UefiRuntimeLib/RuntimeLib.c | 8 ++++---- > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 2 ++ > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 2 ++ > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 ++ > 18 files changed, 35 insertions(+), 11 deletions(-) > >-- >2.21.0.windows.1 > > >