public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [Patch 1/1] BaseTools: Fix incremental build bug
Date: Tue, 13 Aug 2019 04:59:41 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CFAF7@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190813041159.5328-1-bob.c.feng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, August 13, 2019 12:12 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [Patch 1/1] BaseTools: Fix incremental build bug
>
>https://bugzilla.tianocore.org/show_bug.cgi?id=2078
>
>This is a build tool regression issue that
>is introduced by multiple-process-autogen.
>
>The workspace timestamp value is not pass
>to module autogen object correctly, so build tool
>does not detect the change of .dsc and ignore the autogen.
>
>This patch is to fix this issue.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>index ed6822334e93..0654b11ad8e4 100644
>--- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>+++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
>@@ -216,11 +216,11 @@ class ModuleAutoGen(AutoGen):
>     #
>     def _InitWorker(self, Workspace, ModuleFile, Target, Toolchain, Arch,
>PlatformFile,DataPipe):
>         EdkLogger.debug(EdkLogger.DEBUG_9, "AutoGen module [%s] [%s]" %
>(ModuleFile, Arch))
>         GlobalData.gProcessingFile = "%s [%s, %s, %s]" % (ModuleFile, Arch,
>Toolchain, Target)
>
>-        self.Workspace = None
>+        self.Workspace = Workspace
>         self.WorkspaceDir = ""
>         self.PlatformInfo = None
>         self.DataPipe = DataPipe
>         self.__init_platform_info__()
>         self.MetaFile = ModuleFile
>@@ -253,11 +253,10 @@ class ModuleAutoGen(AutoGen):
>         self.ReferenceModules = []
>         self.ConstPcd                  = {}
>
>     def __init_platform_info__(self):
>         pinfo = self.DataPipe.Get("P_Info")
>-        self.Workspace =
>WorkSpaceInfo(pinfo.get("WorkspaceDir"),pinfo.get("ActivePlatform"),pinfo.
>get("Target"),pinfo.get("ToolChain"),pinfo.get("ArchList"))
>         self.WorkspaceDir = pinfo.get("WorkspaceDir")
>         self.PlatformInfo =
>PlatformInfo(self.Workspace,pinfo.get("ActivePlatform"),pinfo.get("Target"),
>pinfo.get("ToolChain"),pinfo.get("Arch"),self.DataPipe)
>     ## hash() operator of ModuleAutoGen
>     #
>     #  The module file path and arch string will be used to represent
>--
>2.20.1.windows.1


  reply	other threads:[~2019-08-13  4:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  4:11 [Patch 1/1] BaseTools: Fix incremental build bug Bob Feng
2019-08-13  4:59 ` Liming Gao [this message]
2019-08-13 20:45 ` [edk2-devel] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4CFAF7@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox