From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Mon, 12 Aug 2019 21:59:44 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 21:59:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,380,1559545200"; d="scan'208";a="327570227" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 12 Aug 2019 21:59:43 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 21:59:43 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 21:59:42 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Tue, 13 Aug 2019 12:59:41 +0800 From: "Liming Gao" To: "Feng, Bob C" , "devel@edk2.groups.io" Subject: Re: [Patch 1/1] BaseTools: Fix incremental build bug Thread-Topic: [Patch 1/1] BaseTools: Fix incremental build bug Thread-Index: AQHVUY1H3uxtJ/Nz4EatCr5as/euNab4hLUQ Date: Tue, 13 Aug 2019 04:59:41 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CFAF7@SHSMSX104.ccr.corp.intel.com> References: <20190813041159.5328-1-bob.c.feng@intel.com> In-Reply-To: <20190813041159.5328-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Feng, Bob C >Sent: Tuesday, August 13, 2019 12:12 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [Patch 1/1] BaseTools: Fix incremental build bug > >https://bugzilla.tianocore.org/show_bug.cgi?id=3D2078 > >This is a build tool regression issue that >is introduced by multiple-process-autogen. > >The workspace timestamp value is not pass >to module autogen object correctly, so build tool >does not detect the change of .dsc and ignore the autogen. > >This patch is to fix this issue. > >Cc: Liming Gao >Signed-off-by: Bob Feng >--- > BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py >b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py >index ed6822334e93..0654b11ad8e4 100644 >--- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py >+++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py >@@ -216,11 +216,11 @@ class ModuleAutoGen(AutoGen): > # > def _InitWorker(self, Workspace, ModuleFile, Target, Toolchain, Arch, >PlatformFile,DataPipe): > EdkLogger.debug(EdkLogger.DEBUG_9, "AutoGen module [%s] [%s]" % >(ModuleFile, Arch)) > GlobalData.gProcessingFile =3D "%s [%s, %s, %s]" % (ModuleFile, A= rch, >Toolchain, Target) > >- self.Workspace =3D None >+ self.Workspace =3D Workspace > self.WorkspaceDir =3D "" > self.PlatformInfo =3D None > self.DataPipe =3D DataPipe > self.__init_platform_info__() > self.MetaFile =3D ModuleFile >@@ -253,11 +253,10 @@ class ModuleAutoGen(AutoGen): > self.ReferenceModules =3D [] > self.ConstPcd =3D {} > > def __init_platform_info__(self): > pinfo =3D self.DataPipe.Get("P_Info") >- self.Workspace =3D >WorkSpaceInfo(pinfo.get("WorkspaceDir"),pinfo.get("ActivePlatform"),pinfo. >get("Target"),pinfo.get("ToolChain"),pinfo.get("ArchList")) > self.WorkspaceDir =3D pinfo.get("WorkspaceDir") > self.PlatformInfo =3D >PlatformInfo(self.Workspace,pinfo.get("ActivePlatform"),pinfo.get("Target"= ), >pinfo.get("ToolChain"),pinfo.get("Arch"),self.DataPipe) > ## hash() operator of ModuleAutoGen > # > # The module file path and arch string will be used to represent >-- >2.20.1.windows.1