public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [Patch 1/1 V2] BaseTools: Move buildoptions.py to Common folder
Date: Wed, 14 Aug 2019 04:27:19 +0000	[thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D07E4@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190813094859.13596-1-bob.c.feng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, August 13, 2019 5:49 PM
>To: edk2-devel@lists.01.org; devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [Patch 1/1 V2] BaseTools: Move buildoptions.py to Common folder
>
>https://bugzilla.tianocore.org/show_bug.cgi?id=2081
>
>buildoptions is used by build.py and TargetTxtClassObj.py
>Move buildoptions.py to Common folder so that
>build tool and ECC tool work fine.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
>V2: Add BZ link.
>
> BaseTools/Source/Python/Common/TargetTxtClassObject.py    | 2 +-
> BaseTools/Source/Python/{build => Common}/buildoptions.py | 0
> BaseTools/Source/Python/build/build.py                    | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename BaseTools/Source/Python/{build => Common}/buildoptions.py
>(100%)
>
>diff --git a/BaseTools/Source/Python/Common/TargetTxtClassObject.py
>b/BaseTools/Source/Python/Common/TargetTxtClassObject.py
>index 16cc75ccb7c8..723b9405bf8f 100644
>--- a/BaseTools/Source/Python/Common/TargetTxtClassObject.py
>+++ b/BaseTools/Source/Python/Common/TargetTxtClassObject.py
>@@ -8,11 +8,11 @@
> ##
> # Import Modules
> #
> from __future__ import print_function
> from __future__ import absolute_import
>-from buildoptions import BuildOption,BuildTarget
>+from Common.buildoptions import BuildOption,BuildTarget
> import Common.GlobalData as GlobalData
> import Common.LongFilePathOs as os
> from . import EdkLogger
> from . import DataType
> from .BuildToolError import *
>diff --git a/BaseTools/Source/Python/build/buildoptions.py
>b/BaseTools/Source/Python/Common/buildoptions.py
>similarity index 100%
>rename from BaseTools/Source/Python/build/buildoptions.py
>rename to BaseTools/Source/Python/Common/buildoptions.py
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 4de3f43c2710..4bfa54666bd5 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -24,11 +24,11 @@ import traceback
> import multiprocessing
> from threading import Thread,Event,BoundedSemaphore
> import threading
> from subprocess import Popen,PIPE
> from collections import OrderedDict, defaultdict
>-from buildoptions import BuildOption,BuildTarget
>+from Common.buildoptions import BuildOption,BuildTarget
> from AutoGen.PlatformAutoGen import PlatformAutoGen
> from AutoGen.ModuleAutoGen import ModuleAutoGen
> from AutoGen.WorkspaceAutoGen import WorkspaceAutoGen
> from AutoGen.AutoGenWorker import
>AutoGenWorkerInProcess,AutoGenManager,\
>     LogAgent
>--
>2.18.0.windows.1


      reply	other threads:[~2019-08-14  4:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  9:48 [Patch 1/1 V2] BaseTools: Move buildoptions.py to Common folder Bob Feng
2019-08-14  4:27 ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E4D07E4@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox