From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: liming.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Tue, 13 Aug 2019 21:27:23 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 21:27:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,383,1559545200"; d="scan'208";a="178003199" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 13 Aug 2019 21:27:23 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 13 Aug 2019 21:27:23 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 13 Aug 2019 21:27:22 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Wed, 14 Aug 2019 12:27:20 +0800 From: "Liming Gao" To: "Feng, Bob C" , "devel@edk2.groups.io" Subject: Re: [Patch 1/1 V2] BaseTools: Move buildoptions.py to Common folder Thread-Topic: [Patch 1/1 V2] BaseTools: Move buildoptions.py to Common folder Thread-Index: AQHVUbxa5zXuxtin/UC2CBHSzjQ/Y6b6DYVA Date: Wed, 14 Aug 2019 04:27:19 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D07E4@SHSMSX104.ccr.corp.intel.com> References: <20190813094859.13596-1-bob.c.feng@intel.com> In-Reply-To: <20190813094859.13596-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Feng, Bob C >Sent: Tuesday, August 13, 2019 5:49 PM >To: edk2-devel@lists.01.org; devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [Patch 1/1 V2] BaseTools: Move buildoptions.py to Common folder > >https://bugzilla.tianocore.org/show_bug.cgi?id=3D2081 > >buildoptions is used by build.py and TargetTxtClassObj.py >Move buildoptions.py to Common folder so that >build tool and ECC tool work fine. > >Cc: Liming Gao >Signed-off-by: Bob Feng >--- >V2: Add BZ link. > > BaseTools/Source/Python/Common/TargetTxtClassObject.py | 2 +- > BaseTools/Source/Python/{build =3D> Common}/buildoptions.py | 0 > BaseTools/Source/Python/build/build.py | 2 +- > 3 files changed, 2 insertions(+), 2 deletions(-) > rename BaseTools/Source/Python/{build =3D> Common}/buildoptions.py >(100%) > >diff --git a/BaseTools/Source/Python/Common/TargetTxtClassObject.py >b/BaseTools/Source/Python/Common/TargetTxtClassObject.py >index 16cc75ccb7c8..723b9405bf8f 100644 >--- a/BaseTools/Source/Python/Common/TargetTxtClassObject.py >+++ b/BaseTools/Source/Python/Common/TargetTxtClassObject.py >@@ -8,11 +8,11 @@ > ## > # Import Modules > # > from __future__ import print_function > from __future__ import absolute_import >-from buildoptions import BuildOption,BuildTarget >+from Common.buildoptions import BuildOption,BuildTarget > import Common.GlobalData as GlobalData > import Common.LongFilePathOs as os > from . import EdkLogger > from . import DataType > from .BuildToolError import * >diff --git a/BaseTools/Source/Python/build/buildoptions.py >b/BaseTools/Source/Python/Common/buildoptions.py >similarity index 100% >rename from BaseTools/Source/Python/build/buildoptions.py >rename to BaseTools/Source/Python/Common/buildoptions.py >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 4de3f43c2710..4bfa54666bd5 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -24,11 +24,11 @@ import traceback > import multiprocessing > from threading import Thread,Event,BoundedSemaphore > import threading > from subprocess import Popen,PIPE > from collections import OrderedDict, defaultdict >-from buildoptions import BuildOption,BuildTarget >+from Common.buildoptions import BuildOption,BuildTarget > from AutoGen.PlatformAutoGen import PlatformAutoGen > from AutoGen.ModuleAutoGen import ModuleAutoGen > from AutoGen.WorkspaceAutoGen import WorkspaceAutoGen > from AutoGen.AutoGenWorker import >AutoGenWorkerInProcess,AutoGenManager,\ > LogAgent >-- >2.18.0.windows.1