From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 14 Aug 2019 17:28:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 17:28:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,387,1559545200"; d="scan'208";a="376221547" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 14 Aug 2019 17:28:19 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 14 Aug 2019 17:28:19 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 14 Aug 2019 17:28:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Thu, 15 Aug 2019 08:28:17 +0800 From: "Liming Gao" To: "Xu, Wei6" , "devel@edk2.groups.io" CC: "Wu, Hao A" Subject: Re: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons in CapsuleOnDisk.c Thread-Topic: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons in CapsuleOnDisk.c Thread-Index: AQHVUcVZ6dPdyWwlJkq/Kgj/xGCJ56b7XReA Date: Thu, 15 Aug 2019 00:28:16 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D1216@SHSMSX104.ccr.corp.intel.com> References: <20190813105317.2820-1-wei6.xu@intel.com> In-Reply-To: <20190813105317.2820-1-wei6.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWNlMDA4YzYtM2ZmMy00NDhhLWFiZGQtNTNlZWVlYWJhM2Q5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUEo5Qk5qRW1BN0laRE9lN2R1NzBkY2I4bzVjaVBiVnVXRGRYTmRmd011TEpMUUExNXZjOGg2eUtFeGR2U2ZIbyJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Xu, Wei6 > Sent: Tuesday, August 13, 2019 6:53 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming > Subject: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons= in CapsuleOnDisk.c >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2028 >=20 > Non-Boolean comparisons should use a compare operator > (=3D=3D, !=3D, >, < >=3D, <=3D). >=20 > Cc: Hao A Wu > Cc: Liming Gao > Signed-off-by: Wei6 Xu > --- > MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c b/MdeMod= ulePkg/Application/CapsuleApp/CapsuleOnDisk.c > index 382efa9aa0..b161d1a981 100644 > --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > @@ -742,11 +742,11 @@ IsCapsuleOnDiskSupported ( > ); > if (EFI_ERROR (Status)) { > return FALSE; > } >=20 > - if (OsIndicationsSupported & EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_= SUPPORTED) { > + if ((OsIndicationsSupported & EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY= _SUPPORTED) !=3D 0) { > return TRUE; > } >=20 > return FALSE; > } > -- > 2.16.2.windows.1