From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 14 Aug 2019 19:26:58 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 19:26:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,387,1559545200"; d="scan'208";a="376939662" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 14 Aug 2019 19:26:57 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 14 Aug 2019 19:26:57 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 14 Aug 2019 19:26:56 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 14 Aug 2019 19:26:56 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Thu, 15 Aug 2019 10:26:55 +0800 From: "Liming Gao" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Wu, Hao A" Subject: Re: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry Thread-Topic: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry Thread-Index: AQHVUxBqqJ2nzDbWU0Wv9JC4ES+Goqb7e36w Date: Thu, 15 Aug 2019 02:26:54 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D13D7@SHSMSX104.ccr.corp.intel.com> References: <20190815022314.8244-1-shenglei.zhang@intel.com> In-Reply-To: <20190815022314.8244-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWE0MGU3MjItNjllNi00ZjE1LTg4MDctNDdhOTkwODlmZGIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieUc4cWRYbzJreFwvc09vbFlLeE5YTnB3alZFd3BvTHRiUGhVV2M0aVR6UXFNR1VIYTl5aDdUVWpoeDVYSWFyUXAifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Shenglei: > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, August 15, 2019 10:23 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ;= Wu, Hao A > Subject: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageM= apLevel5Entry >=20 > Initialize PageMapLevel5Entry at the beginning of the function. >=20 > This commit will fix a GCC 4.8.5 build failure introduced by commit > b3527dedc3951f061c5a73cb4fb2b0f95f47e08b. >=20 > OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2 version. > The commit 46f8a6891606746ca8b1e684ac379ce271306dc0 seems not to fix > the build failure completely. >=20 > Cc: Dandan Bi > Cc: Liming Gao > Cc: Hao A Wu > Signed-off-by: Shenglei Zhang > --- > v2: Add comments to state why set initialize to NULL. >=20 > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c b/MdeModule= Pkg/Core/DxeIplPeim/X64/VirtualMemory.c > index 2389f3eb485b..2f1038b1e67e 100644 > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > @@ -652,6 +652,11 @@ CreateIdentityMappingPageTables ( > UINT64 AddressEncMask; > IA32_CR4 Cr4; >=20 > + // > + // set PageMapLevel5Entry to suppress incorrect compiler/analyzer warn= igns Please fix the typo warnigns =3D=3D> warnings Thanks Liming > + // > + PageMapLevel5Entry =3D NULL; > + > // > // Make sure AddressEncMask is contained to smallest supported address= field > // > -- > 2.18.0.windows.1