From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 15 Aug 2019 01:31:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2019 01:31:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,388,1559545200"; d="scan'208";a="167687138" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 15 Aug 2019 01:31:07 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 01:31:07 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 01:31:07 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0439.000; Thu, 15 Aug 2019 16:31:04 +0800 From: "Liming Gao" To: "Wu, Hao A" , "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Bi, Dandan" Subject: Re: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry Thread-Topic: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry Thread-Index: AQHVUxBqqJ2nzDbWU0Wv9JC4ES+Goqb7e36w///M6YCAAJj6wA== Date: Thu, 15 Aug 2019 08:31:04 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D1948@SHSMSX104.ccr.corp.intel.com> References: <20190815022314.8244-1-shenglei.zhang@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D13D7@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That's fine. Thanks! >-----Original Message----- >From: Wu, Hao A >Sent: Thursday, August 15, 2019 3:23 PM >To: Gao, Liming ; Zhang, Shenglei >; devel@edk2.groups.io >Cc: Bi, Dandan >Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer >PageMapLevel5Entry > >> -----Original Message----- >> From: Gao, Liming >> Sent: Thursday, August 15, 2019 10:27 AM >> To: Zhang, Shenglei; devel@edk2.groups.io >> Cc: Bi, Dandan; Wu, Hao A >> Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer >> PageMapLevel5Entry >> >> Shenglei: >> >> > -----Original Message----- >> > From: Zhang, Shenglei >> > Sent: Thursday, August 15, 2019 10:23 AM >> > To: devel@edk2.groups.io >> > Cc: Bi, Dandan ; Gao, Liming >> ; Wu, Hao A >> > Subject: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer >> PageMapLevel5Entry >> > >> > Initialize PageMapLevel5Entry at the beginning of the function. >> > >> > This commit will fix a GCC 4.8.5 build failure introduced by commit >> > b3527dedc3951f061c5a73cb4fb2b0f95f47e08b. >> > >> > OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2 versi= on. >> > The commit 46f8a6891606746ca8b1e684ac379ce271306dc0 seems not to fix >> > the build failure completely. >> > >> > Cc: Dandan Bi >> > Cc: Liming Gao >> > Cc: Hao A Wu >> > Signed-off-by: Shenglei Zhang >> > --- >> > v2: Add comments to state why set initialize to NULL. >> > >> > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c >> b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c >> > index 2389f3eb485b..2f1038b1e67e 100644 >> > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c >> > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c >> > @@ -652,6 +652,11 @@ CreateIdentityMappingPageTables ( >> > UINT64 AddressEncMask; >> > IA32_CR4 Cr4; >> > >> > + // >> > + // set PageMapLevel5Entry to suppress incorrect compiler/analyzer >> warnigns >> >> Please fix the typo warnigns =3D=3D> warnings > > >Hello Liming, > >I will fix the above typo when I push the patch. >Also, I will keep your RB tag from V1 patch since there is only comment >change between the two versions. > >Best Regards, >Hao Wu > > >> >> Thanks >> Liming >> > + // >> > + PageMapLevel5Entry =3D NULL; >> > + >> > // >> > // Make sure AddressEncMask is contained to smallest supported >address >> field >> > // >> > -- >> > 2.18.0.windows.1