From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Sun, 18 Aug 2019 17:48:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Aug 2019 17:48:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,402,1559545200"; d="scan'208";a="378027016" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 18 Aug 2019 17:48:18 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 18 Aug 2019 17:48:18 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 18 Aug 2019 17:48:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.204]) with mapi id 14.03.0439.000; Mon, 19 Aug 2019 08:48:16 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Zhang, Shenglei" , "Wang, Jian J" CC: "Ye, Ting" Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix coding style Thread-Topic: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix coding style Thread-Index: AQHVU/9wv3//e7bgR0SQR8Q9mg9sUab8120AgAAKrwCABMVp4A== Date: Mon, 19 Aug 2019 00:48:15 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D3243@SHSMSX104.ccr.corp.intel.com> References: <20190816065350.21680-1-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable push@ 944bd5cf1d69741f3705983f650f6adad696a7d1 >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Zhang, Shenglei >Sent: Friday, August 16, 2019 3:56 PM >To: Wang, Jian J ; devel@edk2.groups.io >Cc: Ye, Ting >Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix coding style > >Hi All, > >This patch has little impact. So I think it's ok to be checked in before = code >freeze. > >Thanks, >Shenglei > >> -----Original Message----- >> From: Wang, Jian J >> Sent: Friday, August 16, 2019 3:18 PM >> To: Zhang, Shenglei ; devel@edk2.groups.io >> Cc: Ye, Ting >> Subject: RE: [PATCH 1/1] CryptoPkg: Fix coding style >> >> >> Reviewed-by: Jian J Wang >> >> >> > -----Original Message----- >> > From: Zhang, Shenglei >> > Sent: Friday, August 16, 2019 2:54 PM >> > To: devel@edk2.groups.io >> > Cc: Wang, Jian J ; Ye, Ting >> > Subject: [PATCH 1/1] CryptoPkg: Fix coding style >> > >> > Update attribute "Out" to "out". >> > The original "Out" can not pass ECC check. >> > >> > Cc: Jian Wang >> > Cc: Ting Ye >> > Signed-off-by: Shenglei Zhang >> > --- >> > CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c | 2 +- >> > CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c | 2 +- >> > CryptoPkg/Include/Library/BaseCryptLib.h | 2 +- >> > 3 files changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c >> > b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c >> > index f0fcef211d3f..3a827dadfcbd 100644 >> > --- a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c >> > +++ b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c >> > @@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >> > @param[in] SaltSize Salt size in bytes. >> > @param[in] Info Pointer to the application specific = info. >> > @param[in] InfoSize Info size in bytes. >> > - @param[Out] Out Pointer to buffer to receive hkdf va= lue. >> > + @param[out] Out Pointer to buffer to receive hkdf va= lue. >> > @param[in] OutSize Size of hkdf bytes to generate. >> > >> > @retval TRUE Hkdf generated successfully. >> > diff --git a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c >> > b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c >> > index 73deb5bc3614..19d795a4cc16 100644 >> > --- a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c >> > +++ b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c >> > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >> > @param[in] SaltSize Salt size in bytes. >> > @param[in] Info Pointer to the application specific = info. >> > @param[in] InfoSize Info size in bytes. >> > - @param[Out] Out Pointer to buffer to receive hkdf va= lue. >> > + @param[out] Out Pointer to buffer to receive hkdf va= lue. >> > @param[in] OutSize Size of hkdf bytes to generate. >> > >> > @retval TRUE Hkdf generated successfully. >> > diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h >> > b/CryptoPkg/Include/Library/BaseCryptLib.h >> > index da32bb2444fd..8fe303a0b390 100644 >> > --- a/CryptoPkg/Include/Library/BaseCryptLib.h >> > +++ b/CryptoPkg/Include/Library/BaseCryptLib.h >> > @@ -3135,7 +3135,7 @@ RandomBytes ( >> > @param[in] SaltSize Salt size in bytes. >> > @param[in] Info Pointer to the application specific = info. >> > @param[in] InfoSize Info size in bytes. >> > - @param[Out] Out Pointer to buffer to receive hkdf va= lue. >> > + @param[out] Out Pointer to buffer to receive hkdf va= lue. >> > @param[in] OutSize Size of hkdf bytes to generate. >> > >> > @retval TRUE Hkdf generated successfully. >> > -- >> > 2.18.0.windows.1 > > >