From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Sun, 18 Aug 2019 17:48:58 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Aug 2019 17:48:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,402,1559545200"; d="scan'208";a="378027076" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 18 Aug 2019 17:48:58 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 18 Aug 2019 17:48:57 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 18 Aug 2019 17:48:57 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Mon, 19 Aug 2019 08:48:54 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Zhang, Shenglei" , "Gao, Zhichao" CC: "Carsey, Jaben" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Thread-Topic: [edk2-devel] [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Thread-Index: AQHVU/lYQbF+0L+3dEKf58S55hc5Aab8xveAgAAZvICABMb14A== Date: Mon, 19 Aug 2019 00:48:53 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D3252@SHSMSX104.ccr.corp.intel.com> References: <20190816061034.23528-1-shenglei.zhang@intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8231AC@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push @5726bdd9a2dfd188a96129e8c00721f34cf3906e >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Zhang, Shenglei >Sent: Friday, August 16, 2019 3:51 PM >To: Gao, Zhichao ; devel@edk2.groups.io >Cc: Carsey, Jaben ; Ni, Ray >Subject: Re: [edk2-devel] [PATCH v2 1/1] >ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left > >Hi All, > >This is patch to fix build failure. I'd like the patch to be checked in b= efore this >stable tag. > >Thanks, >Shenglei > >> -----Original Message----- >> From: Gao, Zhichao >> Sent: Friday, August 16, 2019 2:19 PM >> To: Zhang, Shenglei ; devel@edk2.groups.io >> Cc: Carsey, Jaben ; Ni, Ray >> Subject: RE: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: >> Replace shift logical left >> >> Reviewed-by: Zhichao Gao >> >> Thanks, >> Zhichao >> >> > -----Original Message----- >> > From: Zhang, Shenglei >> > Sent: Friday, August 16, 2019 2:11 PM >> > To: devel@edk2.groups.io >> > Cc: Carsey, Jaben ; Ni, Ray ; >> > Gao, Zhichao >> > Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace >> > shift logical left >> > >> > Replace the operation to shift logical left with the function LShiftU= 64, >which >> > has the same functionality. >> > The original code causes ShellPkg build failure with build target"-b = NOOPT". >> > >> > Cc: Jaben Carsey >> > Cc: Ray Ni >> > Cc: Zhichao Gao >> > Signed-off-by: Shenglei Zhang >> > --- >> > v2: There is no return target from LShiftU64 in v1 patch. >> > So update code to "Val =3D LShiftU64(Val,32)". >> > >> > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.= c >> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c >> > index 94bafa22ef4c..a569c3c55406 100644 >> > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c >> > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c >> > @@ -294,7 +294,7 @@ DumpUint64 ( >> > >> > Val =3D *(UINT32*)(Ptr + sizeof (UINT32)); >> > >> > - Val <<=3D 32; >> > + Val =3D LShiftU64(Val,32); >> > Val |=3D (UINT64)*(UINT32*)Ptr; >> > >> > Print (Format, Val); >> > -- >> > 2.18.0.windows.1 > > >